squelch

[NeoWizard]

I can't seem to find where the squelch settings are saved. My char name is gandalf, and I don't find anything in the gandalf.prf file relating to items squelch settings.
And it's the only file with todays date.
Doesn't "save options" also save the squelch settings?
If not, the menu is not much user friendly and should be redesign with a save squelch settings inside the "items squelch settings" sub menu.

[PowerDiver]

http://groups.google.com/group/rec.games.roguelike.angband/browse_thread/thread/48880da1e59d3013#

[Magnate]

I can't seem to find where the squelch settings are saved. My char name is gandalf, and I don't find anything in the gandalf.prf file relating to items squelch settings.
And it's the only file with todays date.
Doesn't "save options" also save the squelch settings?
If not, the menu is not much user friendly and should be redesign with a save squelch settings inside the "items squelch settings" sub menu.

IMO squelch settings should be saved in the class.prf files, and reloaded when you load or create a character of that class. As a priest I will always squelch mage books etc.

I guess this needs to be configurable, because some people won't want to have to un-squelch stuff when they start a new character - maybe a Clear Squelch Settings meta-command could do this?

Alternatively we could just have a separate squelch.prf file. We'd still need a reset command though.

In any event, this info should definitely come out of the save file.

Anyone else have any views on this? Any year now I'm going to try and overhaul the whole pref file setup.

[PowerDiver]

What you want to squelch changes over the game. I don't think anything should be loaded automatically, except for something at birth. Priest_Birth_Squelch.prf makes some sort of sense. There could be other files, but those should be loaded only by command if at all. Another thing is that perhaps you should load lists of things to squelch, but there should be nothing about things not squelched. Whatever is read should be or'ed with the squelch settings already set in the savefile. There is no point in unsquelching something that was previously squelched.

Whatever you do, you have to make it foolproof so Tak and I don't get emails asking about squelch bugs that are actually people saving and reloading prf files without understanding the consequences.

[Magnate]

What you want to squelch changes over the game. I don't think anything should be loaded automatically, except for something at birth. Priest_Birth_Squelch.prf makes some sort of sense. There could be other files, but those should be loaded only by command if at all. Another thing is that perhaps you should load lists of things to squelch, but there should be nothing about things not squelched. Whatever is read should be or'ed with the squelch settings already set in the savefile. There is no point in unsquelching something that was previously squelched.

Unless you've died and started a new character. For some of us, that's the vast majority of cases when loading a savefile!

Whatever you do, you have to make it foolproof so Tak and I don't get emails asking about squelch bugs that are actually people saving and reloading prf files without understanding the consequences.

Agreed. Needs careful thought. Fortunately time is one thing we have in abundance.

[PowerDiver]

Unless you've died and started a new character. For some of us, that's the vast majority of cases when loading a savefile!Agreed. Needs careful thought. Fortunately time is one thing we have in abundance.

That's handled by a <class>_birth.prf. The question is whether there is a need for anything else. Or perhaps the squelch choices go into <class>.prf, but they are only applied at birth.