Code: Notes live where?

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • camlost
    Sangband 1.x Maintainer
    • Apr 2007
    • 523

    Code: Notes live where?

    Where is the standard place to store the notes (and autonotes) for a character? I think I found a patch that seems to store them externally, but I assume that it is more common to save it within the savefile.

    Alternately, is there a GPL-compatible note/autonotes patch I can copy from?
    a chunk of Bronze {These look tastier than they are. !E}
    3 blank Parchments (Vellum) {No french novels please.}
  • Pete Mack
    Prophet
    • Apr 2007
    • 6883

    #2
    I don't know about a patch, but V and FA store it in the savefile, and do not keep an external file during the game (as NPP does).

    Comment

    • Nick
      Vanilla maintainer
      • Apr 2007
      • 9637

      #3
      That patch is I suspect where NPP got it's implementation from (or vice versa). NPP originally stored the notes in a separate file, which had several problems. I don't know if there is a patch for the current V setup (although stuff was posted to the angband-dev mailing list). It should be fairly straightforward just to lift one of the current implementations, though - V and FA have good setups, I haven't checked NPP's in a while.
      One for the Dark Lord on his dark throne
      In the Land of Mordor where the Shadows lie.

      Comment

      • camlost
        Sangband 1.x Maintainer
        • Apr 2007
        • 523

        #4
        Originally posted by Nick
        That patch is I suspect where NPP got it's implementation from (or vice versa). NPP originally stored the notes in a separate file, which had several problems. I don't know if there is a patch for the current V setup (although stuff was posted to the angband-dev mailing list). It should be fairly straightforward just to lift one of the current implementations, though - V and FA have good setups, I haven't checked NPP's in a while.
        FA is GPL, right? Is there a list of variants and licenses for those trying to lift code?
        a chunk of Bronze {These look tastier than they are. !E}
        3 blank Parchments (Vellum) {No french novels please.}

        Comment

        • Nick
          Vanilla maintainer
          • Apr 2007
          • 9637

          #5
          Originally posted by camlost
          FA is GPL, right?
          Current version technically not, next one will be. That said, the notes stuff is taken from Jeff Greene's NPP implementation, and modified by me, and we're both signed up members of the GPL push, so I think you're clear. IIRC almost all the GPL-dubious stuff is in the main-xxx.c files, which are well away from any notes content. If you're in any doubt, use the V one.
          One for the Dark Lord on his dark throne
          In the Land of Mordor where the Shadows lie.

          Comment

          Working...
          😀
          😂
          🥰
          😘
          🤢
          😎
          😞
          😡
          👍
          👎