Some Sil issues

[fph]

Hi,
since everyone around is excited by this new variant, I thought I'd give Sil a try.

Here is some first feedback on UI:
* compiling the game: there are no compilation instructions at all, I had to figure it out myself. As compiling the game is the only choice on Linux, I'd have appreciated an INSTALL file. I am still not sure whether Makefile.std was the right choice or if I should've used Makefile.gtk.
* I edited silx to read SIL_X11_FONT_4=10x20; export SIL_X11_FONT_4, but nevertheless the recall window uses the smaller font. Changing window position work, but the font apparently cannot be changed
* the tutorial is great - I wish Angband had something similar
* it seems that I have to set "move with hjkl" on every new char, it is not remembered along characters
* it is quite unintuitive how to open saved games. Especially the fact that I have to type in myself the name of the old char - who remembers those, when they are random-generated? Moreover, what happens to old savefile when the character dies? They seem to be retained; should I just use the same savefile over and over or new ones? Why isn't the last character opened by default?
* it would be good to have in the keyboard shortcut recalled in the "main esc menu", like in most windowing systems - if you read CTRL+S close to the "save" command on the menu, you remember it more easily
* since there is room on the left column, it would be nice to spend one more row to write down what the attack and armor/defense stats are.
* is there an option to change what the terminals are? I like to have older messages on a window, for instance, and I don't see much use for "combat rolls".
* [edit: added] how do I give the command 'L' when I have the roguelike movement keys activated?

Please don't think that I hate the game just by looking at the number of things I am reporting - the game looks great at a first play, and I am making these comments to help improving it!

[half]

* compiling the game: there are no compilation instructions at all, I had to figure it out myself. As compiling the game is the only choice on Linux, I'd have appreciated an INSTALL file. I am still not sure whether Makefile.std was the right choice or if I should've used Makefile.gtk.

There is a compile.txt file, but it is in lib/docs/ . I suppose the UNIX standard is to put these files with capitalised names in the main directory. I've always found that ugly which is why I didn't do it, but I can see that this makes the very first step a bit difficult. I suppose I could distribute the source code zip file in this format.

* I edited silx to read SIL_X11_FONT_4=10x20; export SIL_X11_FONT_4, but nevertheless the recall window uses the smaller font. Changing window position work, but the font apparently cannot be changed

I'm not sure on this one. I don't use X (or *NIX). I did spend a couple of afternoons trying to get some sensible defaults and creating that silx file, but I think I only have about 2 *NIX players so I'm unwilling to spend any more time on it. If you can make it work, then I could improve the game based on your recommendations.

* the tutorial is great - I wish Angband had something similar

Thanks. So do I!

* it seems that I have to set "move with hjkl" on every new char, it is not remembered along characters

I'm confused here. Like every option in every variant, it is saved in the character file, and is only kept if you make a new character using the old character's savefile. I think you may not have noticed this previously due to the odd way in which *NIX savefiles are handled in most variants.

* it is quite unintuitive how to open saved games. Especially the fact that I have to type in myself the name of the old char - who remembers those, when they are random-generated? Moreover, what happens to old savefile when the character dies? They seem to be retained; should I just use the same savefile over and over or new ones? Why isn't the last character opened by default?

I've switched to the same method of opening savefiles as in all other platforms (they have filenames based on the character names and you choose one to load at startup). I think this is better interface design. You are free to rename the files too.

* it would be good to have in the keyboard shortcut recalled in the "main esc menu", like in most windowing systems - if you read CTRL+S close to the "save" command on the menu, you remember it more easily

I think this would make the menu too ugly, and I've never seen this done in a monospaced text menu.

* since there is room on the left column, it would be nice to spend one more row to write down what the attack and armor/defense stats are.

I'm puzzled. There is no room on the left column if the terminal is at its minimum size, and one reason for this is that I do include the attack and defense stats there...

* is there an option to change what the terminals are? I like to have older messages on a window, for instance, and I don't see much use for "combat rolls".

It is probably a command line option, or achievable by modifying the silx file. This is not ideal for *NIX, sorry.

* how do I give the command 'L' when I have the roguelike movement keys activated?

Use control to access any key commands that are covered up by the hjkl keys. (This is mentioned in the last screen of the '?' command)

[fph]

There is a compile.txt file, but it is in lib/docs/ . I suppose the UNIX standard is to put these files with capitalised names in the main directory. I've always found that ugly which is why I didn't do it, but I can see that this makes the very first step a bit difficult.

I see now - I had missed it! I saw the pdf manual in the main dir, and I assumed that this was the only documentation available. Maybe you could move the /docs folder in the main source folder rather than under /libs to make it more visible.

I'm not sure on this one. I don't use X (or *NIX). I did spend a couple of afternoons trying to get some sensible defaults and creating that silx file, but I think I only have about 2 *NIX players so I'm unwilling to spend any more time on it. If you can make it work, then I could improve the game based on your recommendations.

Ok, I'll see if I can get font changing working myself, thanks! Do you confirm that the backend I should work on for UNIX is -mx11 and not -mgtk?

I'm confused here. Like every option in every variant, it is saved in the character file, and is only kept if you make a new character using the old character's savefile. I think you may not have noticed this previously due to the odd way in which *NIX savefiles are handled in most variants.

I've switched to the same method of opening savefiles as in all other platforms (they have filenames based on the character names and you choose one to load at startup). I think this is better interface design. You are free to rename the files too.

I think the confusion here is that we use the word "character" not to mean "character" as in the common world, but as a substitute for "savefile". A savefile can hold multiple characters (as in: the guys that wander in the dungeon, fight monsters and get killed), and it's not clear that when your character dies the thing that one probably wants is not "new character" but "open saved character" with the name of the first guy that you created.

I think this would make the menu too ugly, and I've never seen this done in a monospaced text menu.

In the old days, Borland Turbo C++ and Pascal did it, for instance.

I'm puzzled. There is no room on the left column if the terminal is at its minimum size, and one reason for this is that I do include the attack and defense stats there...

Hmm, you are right, I thought there was more free space.

It is probably a command line option, or achievable by modifying the silx file. This is not ideal for *NIX, sorry.

No, this is fine - I'll check how one can do it. I asked because terminal configuration is in the options menu in most Angband variants.

Use control to access any key commands that are covered up by the hjkl keys. (This is mentioned in the last screen of the '?' command)

I know, but on my platform adding ctrl works for lowercase commands (like 'l', lowercase L, look at object and monsters), but not for uppercase ones (like uppercase L, shift the map around). Is this a UNIX-only issue? If so, I can try and look into it myself.

Thanks for the answers, and once again, excellent game!

[half]

I know, but on my platform adding ctrl works for lowercase commands (like 'l', lowercase L, look at object and monsters), but not for uppercase ones (like uppercase L, shift the map around). Is this a UNIX-only issue? If so, I can try and look into it myself.

Ah, I think L might be unavailable given that l is ^l. If you want it, then add it to pref.prf (search for ^l to see where and how to add it). Sorry about that.

[Michael Drinen]

You can hit ctrl-l to get into "look mode" then use hjkl to move to the thing you want to look at. I'm note sure if this does the same thing as the L command is supposed to do...

...Ah, L is the "shift the map around" command (what W does in vanilla when you use roguelike keys). Haven't gotten that to work in Sil, but you can use "look mode" that I described and try to look at something that is off the screen and that mostly works.

[half]

OK, for future versions, I've made W do this, as it was unused.

[Starhawk]

An interesting bug last night:

I lost my map memory to a Mewlip and was blinded. I was stumbling away from a large group of monsters, bouncing off walls and such, and stumbled into a room (where I'd been before I lost my memory).

A bastard sword lying on the floor became visible while I was still blinded. Very weird.

[debo]

Did you walk over the sword? I think sometimes you might be able to feel what's on the floor. (I could be 100% wrong about that.)

[Starhawk]

No, I wouldn't have thought that to be unusual. The sword lit up when it was two or three squares away.

[half]

An interesting bug last night:

I lost my map memory to a Mewlip and was blinded. I was stumbling away from a large group of monsters, bouncing off walls and such, and stumbled into a room (where I'd been before I lost my memory).

A bastard sword lying on the floor became visible while I was still blinded. Very weird.

Must be due to the particular way I got these things to work (which was a bit tricky -- items in V can't have different colours depending on circumstances). I've made a note of the bug, though it is obviously not top priority.

[electragician]

I'm not sure on this one. I don't use X (or *NIX). I did spend a couple of afternoons trying to get some sensible defaults and creating that silx file, but I think I only have about 2 *NIX players so I'm unwilling to spend any more time on it. If you can make it work, then I could improve the game based on your recommendations.

1st: Thanks for the game, half! It's awesome!

2nd: fph, I figured out how to adjust the font size on Linux/x11.

In the config.h file, there's a section marked

/*
 * OPTION: Default fonts (when using X11)
 */
#define DEFAULT_X11_FONT_0		"10x20"
#define DEFAULT_X11_FONT_1		"9x15"
#define DEFAULT_X11_FONT_2		"9x15"
#define DEFAULT_X11_FONT_3		"5x8"
#define DEFAULT_X11_FONT_4		"5x8"
#define DEFAULT_X11_FONT_5		"5x8"
#define DEFAULT_X11_FONT_6		"5x8"
#define DEFAULT_X11_FONT_7		"5x8"

Just edit it to use your desired fonts, in the respective windows. FONT_3 and FONT_4 correlate to the Combat Rolls and Recall windows, respectively. I use:

/*
 * OPTION: Default fonts (when using X11)
 */
#define DEFAULT_X11_FONT_0		"10x20"
#define DEFAULT_X11_FONT_1		"9x15"
#define DEFAULT_X11_FONT_2		"9x15"
#define DEFAULT_X11_FONT_3		"9x15"
#define DEFAULT_X11_FONT_4		"7x13"
#define DEFAULT_X11_FONT_5		"5x8"
#define DEFAULT_X11_FONT_6		"5x8"
#define DEFAULT_X11_FONT_7		"5x8"

I have no idea what I'm doing with the rest of this... I'm not a coder, though I've used Linux since the 90s.

I use Makefile.std to compile. I comment out the default section:

## Standard -- "main-x11.c" & "main-gcu.c"
##
#CFLAGS = -Wall -O1 -pipe -g -D"USE_X11" -D"USE_GCU"
#LIBS = -lX11 -lcurses

and uncomment and slightly modify the following section (modification of this section might not be necessary, I think you could probably be fine with just uncommenting the relevant section).

##
## Variation -- this might work better than the suggestion above
##
CFLAGS = -I/usr/include/ \
         -Wall -O2 -fno-strength-reduce -fomit-frame-pointer \
         -D"USE_X11" -D"USE_GCU" \
         -D"USE_TPOSIX" -D"USE_CURS_SET"
LIBS = -lX11 -lncurses
LDFLAGS = -s

You can either leave, or delete, the silx lines concerning font sizes. As you noted, they are completely ignored. The window positioning and size lines seem to work fine though.

Anyway, if you are like me and have bad eyesight, this will help get you some usable fonts. I don't know enough to be able to determine why the actual environment variables being set in the silx files aren't working. That said, the game only takes a minute or so to compile and work around it.

Before

After

[half]

Thanks for your help with this. A player called jdh saw your post here and showed me how to fix this. It turned out that in maid-x11.c there were strings that still said ANGBAND_ instead of SIL_ which was causing the problem. It is fixed for Sil 1.1.1 (or at least it should be -- I can't easily test the fix).

[electragician]

Thanks for your help with this. A player called jdh saw your post here and showed me how to fix this. It turned out that in maid-x11.c there were strings that still said ANGBAND_ instead of SIL_ which was causing the problem. It is fixed for Sil 1.1.1 (or at least it should be -- I can't easily test the fix).

Awesome, thanks so much for following up on it!

I compiled the new version and tested your fix (fwiw, on Crunchbang Linux, a distribution based on Debian) and it works perfectly.

Thanks again!