Player's options are not restored (from savefile) when creating a new chars

[t4nk]

Now options are in struct player, which gets memset in player_init() (player-birth.c):

    /* Wipe the player */
    memset(p, 0, sizeof(struct player));

So all options are reset to 0. Then options_init_defaults() is called (also from player_init()). Note that player_init() is called after trying to load savefile (ui-game.c):

    /* Try loading */
    if (file_exists(savefile) && !savefile_load(savefile, arg_wizard))
        quit("Broken savefile");

    /* No living character loaded */
    if (player->is_dead || new_game) {
        character_generated = false;
        textui_do_birth();
    }

textui_do_birth() calls player_init() via do_cmd_birth_reset().
Is it working as designed? I'd prefer the game to remember my options (roguelike keyset, etc), like it did before, even if I'm creating a new char.

[Carnivean]

New characters could be for a new user, so the slate is left clean. Descendants of an existing character get the options for the ancestor's player.

[takkaria]

Thanks, I've submitted a pull request that fixes this behaviour now.

[Nick]

Thanks, I've submitted a pull request that fixes this behaviour now.

...aaaand it's in the latest nightly build.