Adding Oangband magic realms/spellbooks. What changes do I need to make?

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • Nick
    Vanilla maintainer
    • Apr 2007
    • 9634

    Originally posted by Elfin Jedi
    How do I change the default preferences for tilesets? Right now I have to turn the graphics off every time I redownload from github, because of the monsters and terrain I've added.
    The tile stuff is pretty much all in lib/tiles/<name of tileset> - the relevant graf-***.prf has all the tile definitions for monsters.

    Originally posted by Elfin Jedi
    And how do I add a TIMED_DEC:CUT message for the FAangband spell "Reduce Cuts and Poison"?
    You can change the messages for status effects in lib/gamedata/player_timed.txt; I think that's what you're after.
    One for the Dark Lord on his dark throne
    In the Land of Mordor where the Shadows lie.

    Comment

    • Elfin Jedi
      Adept
      • Mar 2013
      • 102

      Originally posted by Nick
      The tile stuff is pretty much all in lib/tiles/<name of tileset> - the relevant graf-***.prf has all the tile definitions for monsters.
      Actually, what I want to do is turn them off, by default. I'd prefer the ASCII map.

      Originally posted by Nick
      You can change the messages for status effects in lib/gamedata/player_timed.txt; I think that's what you're after.
      I actually branched off of 4.0.5 which doesn't have a player_timed.txt yet, and have been waiting for the next release to update the Vanilla code. Would you recommend keeping things more up to date than that? When is the next Vanilla release likely to be?

      Either way though the cuts are handled separately in player-timed.c, because there are different levels of severity, what I am trying to do is make a message for the Reduce Cuts and Poison spell that indicates that it actually had an effect on any cuts that the player had. I probably should look at FAangband some more to see how it is handled there, because right now I don't even have an idea of how it should work.

      Comment

      • Elfin Jedi
        Adept
        • Mar 2013
        • 102

        Oh... there doesn't seem to be a message in FAangband. Maybe I will leave it and move on to the next spell on my list.

        Comment

        • Derakon
          Prophet
          • Dec 2009
          • 9022

          Originally posted by Elfin Jedi
          I have the Giant bronze dragon flies breathing confusion properly now.
          Congrats! I admit to missing the bronze dragons.

          Comment

          • Nick
            Vanilla maintainer
            • Apr 2007
            • 9634

            Originally posted by Elfin Jedi
            Actually, what I want to do is turn them off, by default. I'd prefer the ASCII map.
            Do you mean turn them off in a particular front end (I think only the windows port has graphics on by default), or disable them at a deeper level?

            Originally posted by Elfin Jedi
            I actually branched off of 4.0.5 which doesn't have a player_timed.txt yet, and have been waiting for the next release to update the Vanilla code. Would you recommend keeping things more up to date than that?
            Up to you, really. There have been a *lot* of changes since 4.0.5, which I am obviously in favour of (or I wouldn't be making them). In particular there has been a lot more pushing of stuff out to the data files, which make modding easier in general.

            Originally posted by Elfin Jedi
            When is the next Vanilla release likely to be?
            Ha. Haha. Hahahahahahahahaha. ha.

            I am currently working on monster pathfinding, and after that will be doing the monster list revamp. That should be it for major changes, and the rest is bugfixing and balance (which sounds easy when you say it quickly). I'm hoping to have 4.1 out about the middle of the year, but there are many variables in the process.
            One for the Dark Lord on his dark throne
            In the Land of Mordor where the Shadows lie.

            Comment

            • Elfin Jedi
              Adept
              • Mar 2013
              • 102

              Originally posted by Nick
              Do you mean turn them off in a particular front end (I think only the windows port has graphics on by default), or disable them at a deeper level?
              I use windows, and the graphics are on by default. I am trying to turn them off by default.

              Originally posted by Nick
              I am currently working on monster pathfinding, and after that will be doing the monster list revamp. That should be it for major changes, and the rest is bugfixing and balance (which sounds easy when you say it quickly). I'm hoping to have 4.1 out about the middle of the year, but there are many variables in the process.
              What all are you doing with the monster list? I might be able to help. I am adding all the monsters from Unangband, and a few non-Zelazny ones from PosChengband to my game.

              Edit: I've seen these links already http://angband.oook.cz/forum/showthread.php?t=4494, http://trac.rephial.org/ticket/443.

              Comment

              • Nick
                Vanilla maintainer
                • Apr 2007
                • 9634

                Originally posted by Elfin Jedi
                I use windows, and the graphics are on by default. I am trying to turn them off by default.
                OK, what you need to change is in src/win/win-layout.c.

                Originally posted by Elfin Jedi
                What all are you doing with the monster list? I might be able to help. I am adding all the monsters from Unangband, and a few non-Zelazny ones from PosChengband to my game.
                I have some general ideas, and there are some in this thread (which I have still failed to contribute to properly. Part of my problem here is my thoughts are still not sufficiently well-formed; I will make an effort to actually reply to that thread some time soon.
                One for the Dark Lord on his dark throne
                In the Land of Mordor where the Shadows lie.

                Comment

                • Elfin Jedi
                  Adept
                  • Mar 2013
                  • 102

                  On github I actually didn't fork my variant from Angband, because I didn't want to be accidentally attempting to push my changes onto Angband, I reuploaded the code I had downloaded.

                  Is there an easy way to pull changes into my variant from Angband when I am not forked from it? Or change whether I am forked from it? I already have a fork from Angband, but I was keeping it separate in case I want to contribute to Angband directly without trying to push all my variant's changes into vanilla angband. Unless there is a way to selectively choose which changes you want to include in a pull request...?

                  Comment

                  • Pete Mack
                    Prophet
                    • Apr 2007
                    • 6883

                    Easy? No.
                    Consider the following scenario: I have developed a small experimental project A in its own Git repo. It has now matured, and I'd like A to be part of larger project B, which has its own big repos...

                    Comment

                    • Derakon
                      Prophet
                      • Dec 2009
                      • 9022

                      Honestly the easy way to do it probably would be to make a new repository that is a fork from Angband, make patches from your commits on your prior repository, then apply those patches to the new repository.

                      Comment

                      • Elfin Jedi
                        Adept
                        • Mar 2013
                        • 102

                        Ok,

                        "If you want to merge project-a into project-b:

                        cd path/to/project-b
                        git remote add project-a path/to/project-a
                        git fetch project-a
                        git merge --allow-unrelated-histories project-a/master # or whichever branch you want to merge
                        git remote remove project-a"

                        So, if project-a = Angband and project-b = my variant (VarAngband), first I will need to ignore the final line "git remote remove project-a", because that is assuming that mine is project-a.

                        Next, where do I find the path folder/directory/thingy? It doesn't seem to be in my Documents/GitHub folder or any of its subfolders.

                        Edit: Oh, I didn't know you could make commits into patches.
                        Last edited by Elfin Jedi; April 13, 2017, 21:05.

                        Comment

                        • Derakon
                          Prophet
                          • Dec 2009
                          • 9022

                          Originally posted by Elfin Jedi
                          Ok,Edit: Oh, I didn't know you could make commits into patches.
                          The output of `git diff` is a valid patch that can be applied via `git apply`. You may also be able to use the `git cherry-pick` command to do this directly, though it requires the repository you want to add the changes to to be able to "see" the repository you want to pull from.

                          Comment

                          • Elfin Jedi
                            Adept
                            • Mar 2013
                            • 102

                            Are those command line only functions then? I haven't done much with command lines yet, mostly just changing directories and making makefiles. (Or anything with Git Shell besides updating the Microsoft support for it.) I'll have to find some instructions.

                            Comment

                            • AnonymousHero
                              Veteran
                              • Jun 2007
                              • 1393

                              Originally posted by Elfin Jedi
                              On github I actually didn't fork my variant from Angband, because I didn't want to be accidentally attempting to push my changes onto Angband, I reuploaded the code I had downloaded.
                              Just a little tip I picked up from someone else: Do
                              Code:
                              git remote origin set-url --push no_push
                              and you can rest easy knowing that you'll never accidentally push to upstream .

                              Comment

                              • Derakon
                                Prophet
                                • Dec 2009
                                • 9022

                                Originally posted by Elfin Jedi
                                Are those command line only functions then? I haven't done much with command lines yet, mostly just changing directories and making makefiles. (Or anything with Git Shell besides updating the Microsoft support for it.) I'll have to find some instructions.
                                Those are shell commands, yes. In my biased opinion, it's worth learning to use the command line, but there's probably some way to achieve what you want to do without it.

                                Originally posted by AnonymousHero
                                and you can rest easy knowing that you'll never accidentally push to upstream
                                You can't do that anyway; you don't have permissions. About the worst you can do is pester Nick with pull requests, which he (and you) can freely cancel.

                                Comment

                                Working...
                                😀
                                😂
                                🥰
                                😘
                                🤢
                                😎
                                😞
                                😡
                                👍
                                👎