How do we submit code changes

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • calris
    Adept
    • Mar 2016
    • 194

    How do we submit code changes

    The map not refreshing when running caused a map panel change was bugging me, so I added a force redraw in the disturb() function if the player was running - works a treat.

    Where do I submit the patch for review?
  • Derakon
    Prophet
    • Dec 2009
    • 9022

    #2
    Originally posted by calris
    The map not refreshing when running caused a map panel change was bugging me, so I added a force redraw in the disturb() function if the player was running - works a treat.

    Where do I submit the patch for review?
    In an ideal world, you'd have a GitHub repository forked from the main repository, you'd push your change to your repository, and then you'd submit a pull request to the main repository (there'd be a big green button on your repository saying "Submit pull request").

    If that all sounds like Greek, then just post the patch here, and I'm sure Nick will see it at some point.

    Comment

    • Nick
      Vanilla maintainer
      • Apr 2007
      • 9634

      #3
      Ideally,
      1. Set yourself up an account on github;
      2. Clone the main Angband repository;
      3. Make changes in a local branch and push them back to github;
      4. Submit a pull request (if you look at your changes on github, you should be prompted to do that).


      Failing that, posting the patch (or a link to it) here should be fine.

      EDIT: I seem to be a clone of Derakon
      Last edited by Nick; March 20, 2016, 04:34. Reason: Freaked out
      One for the Dark Lord on his dark throne
      In the Land of Mordor where the Shadows lie.

      Comment

      • calris
        Adept
        • Mar 2016
        • 194

        #4
        Done and done

        Comment

        Working...
        😀
        😂
        🥰
        😘
        🤢
        😎
        😞
        😡
        👍
        👎