Implementing the restructure changes

[Carnivean]

Feature or bug?

Bug. It was noted in the beta thread, but I thought Nick had resolved it?

[Nick]

Bug. It was noted in the beta thread, but I thought Nick had resolved it?

Yes, I think I have now.

[PowerWyrm]

Currently implementing 5cf8776: moving from old to atomic effect, "CURE_NONORLYBIG" lost the ability to cure hallucinations. This is true for both activation.txt and object.txt (!Life).

[PowerWyrm]

More activation changes:
- "MON_SLOW" was before a "BOLT_AWARE", but is now a "BOLT_STATUS" in activation.txt; same for "POLYMORPH"
- "SHROOM_PURGING" was curing poison (not mentioned in the description), now it doesn't

[PowerWyrm]

From 8cecbfb: the "DARKNESS" effect has been split in two, "DARKEN_AREA" and "TIMED_INC:BLIND". The problem with incrementing the "BLIND" counter is that it only checks vs the innate protection, that is PROT_BLIND. The old darkness effect was also checking vs RES_DARK. This makes half-orcs, which are innately resistant to darkness, suffer from blindness when reading a scroll of darkness, which is silly...

No idea where to put the check though. As an extra parameter to the TIMED_INC effect probably.

Old code:

if (!player_resists(context->player, ELEM_DARK))
    {
        int amount = effect_calculate_value(context, FALSE);

        player_inc_timed(context->player, TMD_BLIND, amount, TRUE, TRUE);
    }
    wieldeds_notice_element(context->player, ELEM_DARK);

Need to pass ELEM_DARK somewhere and check vs resistance + notice the element.

Another little change: the DARKNESS effect was a radius-3 ball doing 10 damage, so the DARKEN_AREA effect should have p2=3 and a dice:10 line.

[PowerWyrm]

In the same vein, potions of experience were restoring lost exp before increasing it. Now they just do GAIN_EXP.

[PowerWyrm]

Potions of salt water were paralyzing the character independently of having FA. The INC_TIMED effect now always checks for corresponding protection (PARALYZE/FA), so the paralyzing effect is now gone if you have FA.

[Nick]

From 8cecbfb: the "DARKNESS" effect has been split in two, "DARKEN_AREA" and "TIMED_INC:BLIND". The problem with incrementing the "BLIND" counter is that it only checks vs the innate protection, that is PROT_BLIND. The old darkness effect was also checking vs RES_DARK. This makes half-orcs, which are innately resistant to darkness, suffer from blindness when reading a scroll of darkness, which is silly...

No idea where to put the check though. As an extra parameter to the TIMED_INC effect probably.

Old code:

if (!player_resists(context->player, ELEM_DARK))
    {
        int amount = effect_calculate_value(context, FALSE);

        player_inc_timed(context->player, TMD_BLIND, amount, TRUE, TRUE);
    }
    wieldeds_notice_element(context->player, ELEM_DARK);

Need to pass ELEM_DARK somewhere and check vs resistance + notice the element.

Another little change: the DARKNESS effect was a radius-3 ball doing 10 damage, so the DARKEN_AREA effect should have p2=3 and a dice:10 line.

I think the correct way to solve all this is to allow DARK_WEAK to damage the player, and have a handler for it in project-player.c. That way the blindness effect can just be put in the handler, as can the check against RES_DARK.

[Ingwe Ingweron]

In the same vein, potions of experience were restoring lost exp before increasing it. Now they just do GAIN_EXP.

If I recall correctly, !Experience have not restored lost experience for several past versions now. The change was that they used to be limited when @ experience was fairly early in the game, but in 3.5 they delivered the full 100,000 exp. points regardless of @ level. If @ had lost some experience, the points were applied to the loss first and any remaining increased experience.

[Nick]

If I recall correctly, !Experience have not restored lost experience for several past versions now. The change was that they used to be limited when @ experience was fairly early in the game, but in 3.5 they delivered the full 100,000 exp. points regardless of @ level. If @ had lost some experience, the points were applied to the loss first and any remaining increased experience.

This is correct, with the added feature that if adding 100,000 XP still doesn't fully restore player XP, then player max XP is increased by 10,000.

[PowerWyrm]

This is correct, with the added feature that if adding 100,000 XP still doesn't fully restore player XP, then player max XP is increased by 10,000.

Ah ok, didn't see that...

[PowerWyrm]

More atomic effects problems: "PROJECT_LOS" is used to map multiple effects that had different parameters which were lost in the process.

- the "dispel" effects: damage boost + check vs aware
- haste monsters: no damage boost + no check vs aware
- confuse/slow/sleep monsters: no damage boost + check vs aware
- the "dispel all" effect (staff of Power): damage boost + no check vs aware

The fix should probably to add a "PROJECT_LOS_AWARE" effect and keep the p2 parameter for damage boost.

[Nick]

More atomic effects problems: "PROJECT_LOS" is used to map multiple effects that had different parameters which were lost in the process.

- the "dispel" effects: damage boost + check vs aware
- haste monsters: no damage boost + no check vs aware
- confuse/slow/sleep monsters: no damage boost + check vs aware
- the "dispel all" effect (staff of Power): damage boost + no check vs aware

The fix should probably to add a "PROJECT_LOS_AWARE" effect and keep the p2 parameter for damage boost.

I think this is mostly right (eg it's sleep, confuse and turn undead that check vs aware), and I need to go and check all these guys individually.

[PowerWyrm]

Artifact activation messages are used for randarts. Unfortunately, randarts also have their names randomized, which breaks the activation format. Basically, an artifact "The something of Foo" should have an activation message like "The {kind} does something..." and an artifact "The something 'Foo'" should have an activation message like "{name} does something...". Otherwise, you get funny messages like "Of Arath glows deep blue...".

[PowerWyrm]

When porting activations to a text file, most artifact activation messages were tied to the corresponding activation. In the case an activation was used by more than one artifact, an alternate message was added in artifact.txt for that artifact. Unfortunately, the alt_msg parameter of the artifact structure is never used in the code, so all artifacts get the base activation message. For example, Narya should say "Narya glows deep red..." (alternate message), but instead it says "The Ring of Fire lets out a shrill wail..." (base PROTEVIL message).