OS X Window Scaling

[molybdenum]

I've been poking around the source to fix the window resize issue (1743). While the basic fix is easy, getting it to work with the existing drawing code is turning out to be a pain. I was wondering if there was a rationale for drawing the views in that manner; I don't want to rip out a lot of code if there was a purpose for it.

I'm a Cocoa developer, so I'm seeing a lot of other things that could be cleaned up. Should I file tickets or should I just make changes and issue pull requests? I don't want to muck up any workflows you guys have.

[takkaria]

I've been poking around the source to fix the window resize issue (1743). While the basic fix is easy, getting it to work with the existing drawing code is turning out to be a pain. I was wondering if there was a rationale for drawing the views in that manner; I don't want to rip out a lot of code if there was a purpose for it.

I'm a Cocoa developer, so I'm seeing a lot of other things that could be cleaned up. Should I file tickets or should I just make changes and issue pull requests? I don't want to muck up any workflows you guys have.

I don't think we really have a Cocoa workflow at the moment. Myshkin has been mostly doing Cocoa stuff but I don't think he's worked on the code for a long time. I think (and I'm sure myshkin will correct me if I'm wrong) you're good to go ahead and submit pull requests. Cocoa could definitely do with some love.

[Nick]

I'm a Cocoa developer, so I'm seeing a lot of other things that could be cleaned up. Should I file tickets or should I just make changes and issue pull requests? I don't want to muck up any workflows you guys have.

Oh yes please just fix it for us.

[scud]

Oh yes please just fix it for us.

What Nick said.

[Pete Mack]

What Nick said.

Ditto. I worked on the Carbon port about 10 years back; now that Carbon is no longer supported, OSX users need a Compleat Cocoa Port... Unfortenately for me, I am now a Windows 8/Metro user...

[molybdenum]

I submitted a pull request a few days ago and wasn't sure if I should announce it here as well (another thread made me think it might be advisable). I was able to get resizing in without changing too much of the drawing code. The only problem is that when you change fonts or enter full screen, you need to bump the mouse or tap a key to get it to redraw. Otherwise, it's quite playable.

I'm swamped with work for the next few weeks, but after that, I should have some time to give the code a proper cleanup. I just wanted to get the main changes out so people could actually play.

[Derakon]

Hooray, excellent news! Thank you very much for working on this. I'll try to notify the other devs in #angband-dev about the pullreq in case they haven't seen it yet; I don't personally have permission to accept them.