Minor versioning issue with 3.5-dev

[bron]

I recently posted a dump to the competition ladder, but the line at the top of the dump that should have said "[Angband 3.5-dev Character Dump]" instead said only "[Angband Character Dump]". This is only an issue because that meant that the competition ladder software had trouble digesting the dump. I am building from source on a gentoo linux box.

I looked into this, and the problem seems to be that src/Makefile includes

  CFLAGS += -DBUILD_ID=${VERSION}  ...

Which in turn forces buildid.c / buildid.h to use the VERSION from the command-line. However, VERSION doesn't seem to have a value.

I'm using just the simple commands recommended in the "compliing.txt" file, e.g.:

    ./autogen.sh
    ./configure --with-no-install --disable-x11 --prefix=`pwd`
    make

I was able to fix my problem by removing the -DBUILD_ID from CFLAGS, so the buildid.c/buildid.h will just use the defaults. I don't know the "right" way to deal with this (admittedly very minor) issue, or even if it is worth anybody's time to do anything about it.

[Nick]

Yeah, that whole process is a bit intricate, and clearly incomplete. It should be fixed at some point.