Quality squelching

[Raggy]

...are not being saved.

Or im missing something?

Go to squelch->then go to quality->set pointy to "good"->go to main menu->save options->save and exit game
Reload game->squelch settings->quality: everything is back to nothing.

[Magnate]

...are not being saved.

Or im missing something?

Go to squelch->then go to quality->set pointy to "good"->go to main menu->save options->save and exit game
Reload game->squelch settings->quality: everything is back to nothing.

You're playing on Windows, I presume. This is a well-known and little-understood Windows bug, ticket #1318. If you can work out under exactly what conditions it occurs, we'd be very grateful. It doesn't reproduce for all Windows players under all conditions, and it doesn't occur for non-Windows platforms. I think.

[Jazerus]

Quality squelch is saved for me on Windows, but I also have Angband installed outside of Program Files. Preference save settings in general on Windows may be related to UAC if it turns out those who have the issue have Angband installed in UAC-controlled directories.

The correct behavior persists for me across all builds, official and nightly.

[Timo Pietilä]

Quality squelch is saved for me on Windows, but I also have Angband installed outside of Program Files. Preference save settings in general on Windows may be related to UAC if it turns out those who have the issue have Angband installed in UAC-controlled directories.

The correct behavior persists for me across all builds, official and nightly.

Not the UAC case, I use XP and play outside of Program Files, still doesn't save the settings.

I'm surprised to hear that this is Windows-problem. Maybe some of you should really use Windows to code, it is still huge majority of desktop computers (something like 90% of computer I think). I have two totally different XP machines, only similar thing is that they both are XPSP3 and both have ATI display cards (but different models).

Exact situation where saving doesn't happen is "I exit the game, then reload". I can tweak everything and it doesn't save the settings.

Anyway this has to have something to do with settings saved in save file, those settings are not saved anywhere else (not even if I save all my options in pref-file, they are not there). If there can be this kind of error now who knows what else don't get saved later. Monster inventories? Your gear?

Error has occurred between rd39a356436 and next nightly there was available in rephial. Something in there changed that behavior. Track that down, and you get the reason why it doesn't work anymore.

[Max Stats]

Quality squelch is saved for me on Windows, but I also have Angband installed outside of Program Files. Preference save settings in general on Windows may be related to UAC if it turns out those who have the issue have Angband installed in UAC-controlled directories.

I had thought of this when I saw the issue, but AFAIK (unless something has changed) squelch settings are saved in the character file, so if it were a UAC issue, it wouldn't be possible to save games at all.

Anyway, the whole thing makes me glad I boot to Linux to play Angband.

[Raggy]

You're playing on Windows, I presume. This is a well-known and little-understood Windows bug, ticket #1318. If you can work out under exactly what conditions it occurs, we'd be very grateful. It doesn't reproduce for all Windows players under all conditions, and it doesn't occur for non-Windows platforms. I think.

Well it reproduces for me each time I play, I do nothing special, except modifying the quality squelching, saving options, then eventually exiting the game. Next time I play, settings are gone.

[Magnate]

Well it reproduces for me each time I play, I do nothing special, except modifying the quality squelching, saving options, then eventually exiting the game. Next time I play, settings are gone.

Yes. So we need to know what is different about your system from people playing under Windows who don't have this problem - their settings save and reload fine.

Do you have a pref file somewhere with squelch settings in it? It's possible that your changed settings *are* getting saved and reloaded properly, but then a pref file is being loaded *after* that ...

[Timo Pietilä]

Yes. So we need to know what is different about your system from people playing under Windows who don't have this problem - their settings save and reload fine.

Do you have a pref file somewhere with squelch settings in it? It's possible that your changed settings *are* getting saved and reloaded properly, but then a pref file is being loaded *after* that ...

In my case this is definitely not the case. I do have a pref-file which contains class-specific keymaps, and I have changed font-win.prf, but either of those should not affect quality squelch saving.

Quality squelch settings cannot not be saved in pref-file even if you try, I tested that. I made "save options" and that didn't include quality squelch settings. There is no way you can save them in pref-file in current UI.

This started to appear between rd39a356436 and next nightly edition available to download. What changed there? Couldn't you just reverse whatever changed there that has something to do with squelch?

[Magnate]

Quality squelch settings cannot not be saved in pref-file even if you try, I tested that. I made "save options" and that didn't include quality squelch settings. There is no way you can save them in pref-file in current UI.

Not any more they can't, no - but they used to, and people may have old pref files lying around.

This started to appear between rd39a356436 and next nightly edition available to download. What changed there? Couldn't you just reverse whatever changed there that has something to do with squelch?

Possibly. I haven't looked yet, but I have a feeling it's not an easy problem to spot.

[Timo Pietilä]

Not any more they can't, no - but they used to, and people may have old pref files lying around.

When I "upgrade" I just copy apex, user prefs (class-specific macros/keymaps), font-win.prf, angband.ini and savefiles to new game directory. I have all the old ones still here from who knows how far back (many of them have my own tweaks in edit-files, so not clean savegames).

Anyway, I have never saved squelch-settings, so that can't be the reason for that bug.

Maybe this is compiler error. Have you tried cycgwin gcc for windows-builds? It has been rock-solid platform for my compiling for ages. It seems that there is now couple of .dll:s in root of the game directory that were not there before (rd39a356436 doesn't have those). What is the purpose of those?

[Magnate]

When I "upgrade" I just copy apex, user prefs (class-specific macros/keymaps), font-win.prf, angband.ini and savefiles to new game directory. I have all the old ones still here from who knows how far back (many of them have my own tweaks in edit-files, so not clean savegames).

Anyway, I have never saved squelch-settings, so that can't be the reason for that bug.

Maybe this is compiler error. Have you tried cycgwin gcc for windows-builds? It has been rock-solid platform for my compiling for ages. It seems that there is now couple of .dll:s in root of the game directory that were not there before (rd39a356436 doesn't have those). What is the purpose of those?

Those are the png support, I think.

Sorry, I don't know anything about Windows compilers.

[d_m]

Fizzix saw the bug before we added PNG support (and the DLLs) so I don't think those are the culprit.

[Timo Pietilä]

Fizzix saw the bug before we added PNG support (and the DLLs) so I don't think those are the culprit.

Which version was that? It narrows it down a bit, because it didn't happen in my copies before first dev-version with 3.2.0-xxx-xxxxxxxxxx version numbering, and that already has those .dll:s. Fizzix had to have his dev-version before it could be downloaded from Rephial.

[Raggy]

I just tried the 22 jun nightly.

New char -> random everything

Noticing everything defaults to 'bad'
Set Pointy Melee Weapons to -> good.
Save options
Save Game
Restart
Load savegame
Check quality squelch settings.
Everything now-> no squelch

So its 2 bugs now, it doesn't save, and forgets the defaults.

My environment is a Windows 7 64 bit OS.
It does however work in 3.2.0!

[PowerDiver]

Are any of you windows users capable of a little programming? There are a couple of things one could test to try to narrow down the problem. Anyone willing to try to debug could send me mail for specific suggestions.