[Announce] NPPAngband 0.5.1 WIP 2

[buzzkill]

I believe this is also consistent with Angband. It used to come up with the price for one, round, then multiply. Now the function calculates the price for a group of items, rather than find the price for one and then multiply by the number. So, yes, these things happen. Have people complained about it in Vanilla?

This seems very wrong (though very minor). Aren't prices for items integers? If not then the price should be rounded up when displayed, so that mass quantities cost less than the advertised price, not more. There's no need to replicate a bug.

[murphy]

How about the simple low tech solution of me just including the directory in the default download. Does that work?

Unfortunately no :-( The directory that needs to be created isn't in the angband source tree. The notes file, and also character dump files, go into ~/.angband/VERSION_NAME
where VERSION_NAME is set in defines.h

[d_m]

also for my system I have to do gcu only compile, which means I had to hack up the Makefile.src and Makefile.std [maybe also Makefile.inc for vanilla] to get rid of gtk/* and maybe also snd-sdl.o as dependencies [had to do similar hacking to get vanilla angband to compile too ... so this isn't an issue specific to NPP]

the src/gtk/*.c stuff won't compile for me because I dont have the gtk system header files. but they aren't really dependencies for gcu only compile, so maybe at some point it would be nice to clean up the makefiles so that gcu and x11 dependencies don't get mixed together

When compiling vanilla, are you using autogen.sh and configure and such?

svn co svn://rephial.org/angband/trunk angband-trunk
cd angband-trunk
./autogen.sh
./configure --prefix $DESTINATION
make
make install

Unlike most variants for Linux, you should compile V from outside the source directory (not using the Makefiles in src directly). With configure you should be able to use --enable-curses, --disable-gtk, etc. That said on my Linux server I don't have to say --disable-gtk... configure detects that I don't have it and moves on.

If you're still having problems compiling an unmodified checkout of trunk, let me know. AFAIK it's worked cleanly in Linux for awhile.

[Belgen]

I can't play the sound. Does anyone have this problem?

[murphy]

When compiling vanilla, are you using autogen.sh and configure and such?

Thanks for the suggestion. The answer is No :-( But you inspired me to take another look at it.

Trying to build V trunk, when I get to the configure step, it is not detecting ncurses. In configure.log I see

configure:5167: checking for initscr in -lncurses
configure:5202: gcc -o conftest -g -O2 -DHAVE_CONFIG_H -fno-strength-reduce -W -Wall -Wno-unused-parameter -Wno-missing-field-initializers -pedantic  -I.  conftest.c -lncurses    >&5
cc1: error: unrecognized command line option "-Wno-missing-field-initializers"

My compiler (gcc 3.4.6) doesn't like this -Wno-missing-field-initializers flag, so the ncurses test bombs.

My libncurses actually seems to be ok. If I do

readelf -s /usr/lib/libncurses.so

I can see initscr() in the symbol table.

[murphy]

Got NPP WIP-2a compiled and running.

Only took minor hacking to Makefile.std / Makefile.src

1. remove gtk/* and snd-sdl.o dependencies [known issue]
2. had to remove one compiler flag: -Wmissing-include-dirs

that 2nd step is needed for me because I have a pretty old version of gcc. I had to do the same thing to build WIP1 and WIP2 too, just forgot to mention it

Playtesting so far hasn't turned up any issues, now this is the more fun part of testing :-)

[nppangband]

I can't play the sound. Does anyone have this problem?

I did a search, and the option to turn the sound on is missing. So I think it is fair to say that everyone has this problem. I will fix this.

[nppangband]

This seems very wrong (though very minor). Aren't prices for items integers? If not then the price should be rounded up when displayed, so that mass quantities cost less than the advertised price, not more. There's no need to replicate a bug.

The reason the prices may come out differently when you factor quantities before rounding is the charisma adjustment, and formerly the shopkeeper race adjustment. An arrow may actually cost 1.2 gold with charisma factored in, so it only shows up in bulk purchases.

But I do happen to prefer it the old way as well, so I did change it back. The price is calculated and rounded before the quantities are factored in, so 99 flasks of oil will once again cost 99 gp.

[ekolis]

I wore a cloak which turned out to be cursed, but it still says <unknown>...

edit: also, dropping items in the home ID's them for free!

and aiming an un-id'd wand of light did not id it...

neither did drinking a potion of saltwater!

[nppangband]

I wore a cloak which turned out to be cursed, but it still says <unknown>...

Many of the object names are written incorrectly. I will be fixing that in the next couple days.

edit: also, dropping items in the home ID's them for free!

Worse, it *identifies* them. This is fixed for next time. Until then, enjoy.

and aiming an un-id'd wand of light did not id it...

neither did drinking a potion of saltwater!

Getting an identification by use appears to be broken. I will fix that as well.