Link warning

[Nick]

I've been getting this weird linker warning for a while in FA, and i'm wondering if anyone can enlighten me on it's cause and seriousness:

/usr/bin/ld: Warning: type of symbol `format' changed from 1 to 2 in z-form.o

My z-form.c is vary similar to V3.1.0, the only differences being inclusion of the xchar stuff from NPP (which I don't think can be related) and some use of C_MAKE and KILL instead of C_RNEW and FREE in vformat() (which I guess could be it).

[Pete Mack]

How old is your copy of the linker? It looks there was a patch to ld sometime after early 2004.

[Nick]

How old is your copy of the linker? It looks there was a patch to ld sometime after early 2004.

ld -v says

GNU ld (GNU Binutils for Ubuntu) 2.18.93.20081009

Googling tells me that 2.19 is the latest version - maybe I should try and upgrade first...

...although apparently I have the current Ubuntu binutils package, and I usually don't go deeper than the package level with system modification.

[Pete Mack]

I guess the linker's not the problem. In that case, I have no idea.

[Nick]

It looks like the answer should be that 'format' has been used as a variable name before it's use as a function name in z-form.c; problem is I can't find any such thing. I'm wondering if somehow it's included from some library or include file or something. In any case, it looks more like an annoyance than a worry.

[Magnate]

It looks like the answer should be that 'format' has been used as a variable name before it's use as a function name in z-form.c; problem is I can't find any such thing. I'm wondering if somehow it's included from some library or include file or something.

'format' is one of the arguments taken by file_putf ... do you still use that?

[Nick]

'format' is one of the arguments taken by file_putf ... do you still use that?

It's still hanging around in z-file.c, but not used - and the argument it takes is fmt.

I'm annoyed and baffled about this, but I don't think it's actually causing any problems.

[Magnate]

It's still hanging around in z-file.c, but not used - and the argument it takes is fmt.

The argument is fmt in most places, but it's format in wiz-spoil.c, if you still have that ....

[Nick]

The argument is fmt in most places, but it's format in wiz-spoil.c, if you still have that ....

I think my wizard1.c is the equivalent, and it has no format.

[s0be]

Nick,

Care to share your source tree? I'll chase it down real quick like.

[Nick]

Care to share your source tree? I'll chase it down real quick like.

It has been an issue for at least a couple of versions including the latest, 0.3.6.

[s0be]

ld 2.19.1.... no linker errors here.

[Nick]

ld 2.19.1.... no linker errors here.

Cool. I'll wait the 6 days until the next Ubuntu release, which apparently will have 2.19.1 in it - maybe this time an error will be fixed as well as new ones introduced.