resist fire ego comes with friends in gd08de4a

[saarn]

Items with the rFire ego seem to come with many other resists.

I got a buckler of resist fire that also has rAcid
and then I just got a jerkin of resist fire off Smeagol that has all four basic resists (and ignores base elements).

Seems a bit weird to me-- the jerkin would be called of resistance in older angbands and I think would be considered super sweet at DLVL 16. I hope this is just me getting lucky, not a byproduct of ego by affix. If it is, there should probably be some sort of exponential increase to item goodness based on number of resists.

[Magnate]

Items with the rFire ego seem to come with many other resists.

I got a buckler of resist fire that also has rAcid
and then I just got a jerkin of resist fire off Smeagol that has all four basic resists (and ignores base elements).

Seems a bit weird to me-- the jerkin would be called of resistance in older angbands and I think would be considered super sweet at DLVL 16. I hope this is just me getting lucky, not a byproduct of ego by affix. If it is, there should probably be some sort of exponential increase to item goodness based on number of resists.

How the new ego system works is described on the dev wiki: http://trac.rephial.org/wiki/NewEgos. That's probably too much detail, but the basic issue you're discovering is that an item's name is no longer an exhaustive description of its properties. (Canny readers will recall that sorting out ego naming is top of the list in the v4 contributions thread.)

An item is currently named using its best prefix and best suffix, if it has them. Obviously all base resists are equal, so it will keep the name of whichever it got first. That said, make sure you read the section on Themes, and have a look at lib/edit/ego_themes.txt - once an item acquires more than one affix, it has a chance of acquiring a theme. Resistance is one such theme, which can be aqcuired when an item gets any two base resists. The probabilities are designed such that all four base resists should automatically get the theme, and this change the name to Of Resistance. This should have happened to your jerkin - but if we look closely at ego_themes.txt we can see that in the absence of Durability and Reinforced, the probability is only 28 * 28 * 4 / 34 = 92.2%. When we consider that it failed two other tries for the theme (when the second and third resists were added), the chance of failure is not 7.8% but 2.9%.