UnAngband - inconsistent variable declaration

[Azerath]

Hi,

I've been trying to compile&debug directly from VS2010. I've been able successfully compile and run it, but it required to make some small changes to source code - all of them related to non C compliant variable declaration.

cmd5.c (l:420) has declared 3 variables after if statement. moving them to begining of scope solves the problem.

store.c (l:2425) contains int old_number variable declared inline, moving it to begining of function together with other variables solves the problem.

The source code is taken from download unangband-064a-src.zip

Regards

[andrewdoull]

Thanks - will fix.

I'm a little surprised gcc wasn't picking this up and at least generating warnings.

[Azerath]

Maybe "pedantic" switch to compiler would help? Without this declaration cane be anywhere not only at begining of block.

[zaimoni]

Thanks - will fix.

I'm a little surprised gcc wasn't picking this up and at least generating warnings.

The issues are legal C99, but illegal C90. MSVC is a C90 compiler, and makes no pretence of comprehensive C99 support.

[Azerath]

Pssst! Pssst! hold your horse boy! I'm not an enemy! Next time you would fight with MS evil! :-)

If you want to prevent from Windows corruption in roguelikes world, just create Angband version that prevents in license running from windows systems ;-)