[3.5.1] Aggravation reveals mimics without giving awareness

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • PowerWyrm
    Prophet
    • Apr 2008
    • 2987

    [3.5.1] Aggravation reveals mimics without giving awareness

    Using an aggravating item (for example Zarcuthra) will reveal mimics ("The creeping copper coins wakes up"), but will not give awareness (creeping copper coins will stay a pile of $).

    See process_monster():

    Code:
    		/* Aggravation */
    		if (check_state(p_ptr, OF_AGGRAVATE, p_ptr->state.flags)) {
    			/* Wake the monster and notify player */
    			mon_clear_timed(m_ptr, MON_TMD_SLEEP, MON_TMD_FLG_NOTIFY, FALSE);
    
    			/* Update the health bar */
    			if (m_ptr->ml && !m_ptr->unaware) {
    				
    				/* Hack -- Update the health bar */
    				if (p_ptr->health_who == m_ptr) p_ptr->redraw |= (PR_HEALTH);
    			}
    
    			/* Efficiency XXX XXX */
    			return;
    		}
    IMO, the aggravated mimic should wake up silently and stay unaware like non-aggravated ones.

    Code:
    		/* Aggravation */
    		if (check_state(p_ptr, OF_AGGRAVATE, p_ptr->state.flags)) {
    			/* Wake the monster */
    			mon_clear_timed(m_ptr, MON_TMD_SLEEP, MON_TMD_FLG_NOMESSAGE, FALSE);
    
    			/* Notice the "waking up" */
    			if (m_ptr->ml && !m_ptr->unaware) {
    				/* Dump a message */
    				msg("%s wakes up.", m_name);
    				
    				/* Hack -- Update the health bar (redundant code) */
    				/*if (p_ptr->health_who == m_ptr) p_ptr->redraw |= (PR_HEALTH);*/
    			}
    
    			/* Efficiency XXX XXX */
    			return;
    		}
    Last edited by PowerWyrm; January 13, 2015, 10:56.
    PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!
  • PowerWyrm
    Prophet
    • Apr 2008
    • 2987

    #2
    Ticket #1833.
    PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!

    Comment

    • PowerWyrm
      Prophet
      • Apr 2008
      • 2987

      #3
      On a side note, the health update in that code is redundant and could be removed, because it's already done in mon_clear_timed().
      PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!

      Comment

      Working...
      😀
      😂
      🥰
      😘
      🤢
      😎
      😞
      😡
      👍
      👎