Tweet
If you are aware of the flavor, an unidentified amulet of devotion will appear as "an amulet of devotion" if the hidden WIS bonus is +1. Otherwise, it will appear as "an amulet of devotion <+1>".
Looking at the code, pval is "visible" for jewelry if flavor is aware and pval is non-variable. In the case of amulet of devotion, a WIS bonus of +1 leads to one variable pval which is not displayed. This is correct. If the WIS bonus is not +1, two pvals are attached to the amulet: the first one for WIS (variable), the second one for +1 light radius (non-variable). So the second pval is displayed, which doesn't feel right... even more when you (I)nspect the amulet, which tells you that it affects wisdom, but doesn't tell anything about light.
To make things consistent (see describe_stats in obj-info which doesn't take into account OF_LIGHT), fixed pval with only OF_LIGHT should not be visible until the item is either identified or worn.
Same problem is occuring with rings of light.
Looking at the code, pval is "visible" for jewelry if flavor is aware and pval is non-variable. In the case of amulet of devotion, a WIS bonus of +1 leads to one variable pval which is not displayed. This is correct. If the WIS bonus is not +1, two pvals are attached to the amulet: the first one for WIS (variable), the second one for +1 light radius (non-variable). So the second pval is displayed, which doesn't feel right... even more when you (I)nspect the amulet, which tells you that it affects wisdom, but doesn't tell anything about light.
To make things consistent (see describe_stats in obj-info which doesn't take into account OF_LIGHT), fixed pval with only OF_LIGHT should not be visible until the item is either identified or worn.
Same problem is occuring with rings of light.
Comment