[3.5-dev] New "small" pits prevent some monsters from appearing

[PowerWyrm]

The new pit layout should be:

#############
#11000000011#
#01234543210#
#01236763210#
#01234543210#
#11000000011#
#############

But as coded, the result is:

#############
#11000000011#
#01235553210#
#01236763210#
#01235553210#
#11000000011#
#############

[fizzix]

The new pit layout should be:

#############
#11000000011#
#01234543210#
#01236763210#
#01234543210#
#11000000011#
#############

But as coded, the result is:

#############
#11000000011#
#01235553210#
#01236763210#
#01235553210#
#11000000011#
#############

Thanks for pointing this out, I'll try to fix it tonight.

[fizzix]

I think it's correct as coded. Sometimes the same monster race will appear across multiple slots. So you can sometimes get ones where 4 and 5 are the same, and sometimes where 6 and 7 are the same.

[PowerWyrm]

I think it's correct as coded. Sometimes the same monster race will appear across multiple slots. So you can sometimes get ones where 4 and 5 are the same, and sometimes where 6 and 7 are the same.

???

Currently, the spots where monster race 4 should appear are simply overwritten by monster race 5.

You have for monster race 4:
- place(y0 - 1, x0 - 1)
- place(y0 - 1, x0 + 1)
- place(y0 + 1, x0 - 1)
- place(y0 + 1, x0 + 1)

And for monster race 5:
- for (x = x0 - 1; x <= x0 + 1; x++) place(y0 + 1, x) + place(y0 - 1, x)

which overwrites the 4 previous spots.

For monster race 5, this should be replaced by:
- place(y0 + 1, x0)
- place(y0 - 1, x0)

[fizzix]

oh, I see what you're getting at. That should be fixed, but it actually doesn't overwrite the spot, so it still works as desired but the code is unclear. When it tries to put the new monster there, it finds a monster already there and then gives up.