[3.4RC] There may not be much interesting here...

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • PowerWyrm
    Prophet
    • Apr 2008
    • 2986

    [3.4RC] There may not be much interesting here...

    Level was generated with a D pit and a GCV, I was expecting "superb treasures"...

    In fact, this is easily explained. Excerpt from the code:

    Code:
    if (rating > 250000) rating = 250000;
    
            c->obj_rating += (rating / 10) * (rating / 10);
    obj_rating is coded on an unsigned integer, which maxes at roughly 4e+9. Any WoG, Kelek or high DSM will easily get a max rating of 250k when generated out of depth in a GCV, which boosts the object rating by 625mil. And a GCV easily has more than 7-8 of those, boosting object rating over the MAXINT limit.

    Using a percent of the rating would probably fix the problem:

    Code:
    c->obj_rating += (rating / 100) * (rating / 100);
    This means losing a bit of accuracy with low ratings, but I don't think it matters much what type of "cobwebs" you get on a junk level
    PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!
  • Derakon
    Prophet
    • Dec 2009
    • 9022

    #2
    There are cobwebs of shining mithril here!

    Seriously though, good catch. It's amazing how many rollover bugs we've had to deal with lately; are we just trying for too much resolution or something?

    Comment

    • wobbly
      Prophet
      • May 2012
      • 2627

      #3
      Just watch out for that mithril spider....

      I'm currently searching any level with more then scraps of junks. 2 egos, an artifact, a ring of free action & gloves of slaying was merely "worthwhile" on dlevel 13.

      Comment

      Working...
      😀
      😂
      🥰
      😘
      🤢
      😎
      😞
      😡
      👍
      👎