[3.3] Earthquake

[PowerWyrm]

Fixing #1383 introduced a small bug:

					/* If the quake finished the monster off, show message */
					if (m_ptr->hp < damage && m_ptr->hp >= 0)
						msg("%^s is embedded in the rock!", m_name);
					
					/* Apply damage directly */
					m_ptr->hp -= damage;

					/* Delete (not kill) "dead" monsters */
					if (m_ptr->hp < damage)
					{
						/* Delete the monster */
						delete_monster(yy, xx);

						/* No longer safe */
						sn = 0;
					}

Damage is already applied when checking for death... so monsters with more HPs than the damage value and less than double the damage value will be deleted, when they should not.

[Magnate]

So this should all be one if block, right? If (hp < dam && hp > 0) then do all of

msg("embedded in rock");
hp -= damage;
delete_monster();
sn = 0;

... ?

[Timo Pietilä]

So this should all be one if block, right? If (hp < dam && hp > 0) then do all of

msg("embedded in rock");
hp -= damage;
delete_monster();
sn = 0;

... ?

Maybe "else hp-=damage"?, because if it survives the checks, it has enough HP to live.

Or maybe this

/* Delete (not kill) "dead" monsters */
					if (m_ptr->hp < damage)

should be

/* Delete (not kill) "dead" monsters */
					if (m_ptr->hp < 0)

[PowerWyrm]

Exactly: replace if (m_ptr->hp < damage) by if (m_ptr->hp < 0)

[Magnate]

Exactly: replace if (m_ptr->hp < damage) by if (m_ptr->hp < 0)

Fixed in staging - thanks.