[3.3.0] Delayed level feeling lost after save/load

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • Bee Vortex
    Rookie
    • Jul 2011
    • 12

    [3.3.0] Delayed level feeling lost after save/load

    When you save a game while in a dungeon after the delayed level feeling has been triggered and then reload the game, only the initial part of the feeling shows up. The delayed feeling will only show up after, ehm, a delay.

    Daniel
  • fizzix
    Prophet
    • Aug 2009
    • 3025

    #2
    Originally posted by Bee Vortex
    When you save a game while in a dungeon after the delayed level feeling has been triggered and then reload the game, only the initial part of the feeling shows up. The delayed feeling will only show up after, ehm, a delay.

    Daniel
    Nice catch. This is my fault. I thought I had handled that case, but apparently not. I'll try to fix this shortly.

    Comment

    • bio_hazard
      Knight
      • Dec 2008
      • 649

      #3
      I'm pretty sure I had the second part appear on initial reload of a saved game, then disappear later, then reappear after some time on the level.

      Comment

      • fizzix
        Prophet
        • Aug 2009
        • 3025

        #4
        Originally posted by bio_hazard
        I'm pretty sure I had the second part appear on initial reload of a saved game, then disappear later, then reappear after some time on the level.
        In play-testing I was pretty sure you got both feelings correctly on reload when you had already triggered the second feeling. But something may have changed in the code so this is not so anymore.

        Comment

        • Magnate
          Angband Devteam member
          • May 2007
          • 5110

          #5
          Originally posted by fizzix
          In play-testing I was pretty sure you got both feelings correctly on reload when you had already triggered the second feeling. But something may have changed in the code so this is not so anymore.
          It shouldn't have done - I don't think anything went into 3.3.0 after this which would have affected it.

          We probably need to have a look at exactly what info is saved and loaded about the squares which contribute to the feeling and how many @ has seen.
          "Been away so long I hardly knew the place, gee it's good to be back home" - The Beatles

          Comment

          • fizzix
            Prophet
            • Aug 2009
            • 3025

            #6
            Originally posted by Magnate
            It shouldn't have done - I don't think anything went into 3.3.0 after this which would have affected it.

            We probably need to have a look at exactly what info is saved and loaded about the squares which contribute to the feeling and how many @ has seen.
            yeah it's always been broken. I have no idea how I missed this.

            edit: I have a feeling that fixing this will break save files. Is it worth just keeping the bug for now?
            Last edited by fizzix; August 11, 2011, 23:06.

            Comment

            • Magnate
              Angband Devteam member
              • May 2007
              • 5110

              #7
              Originally posted by fizzix
              yeah it's always been broken. I have no idea how I missed this.

              edit: I have a feeling that fixing this will break save files. Is it worth just keeping the bug for now?
              It's ok, savefiles don't break so easily any more. It just means a new version of wr_dungeon (or whichever function stores the cave[] info).
              "Been away so long I hardly knew the place, gee it's good to be back home" - The Beatles

              Comment

              Working...
              😀
              😂
              🥰
              😘
              🤢
              😎
              😞
              😡
              👍
              👎