Townspeople don't disturb (new option; diff included)

[Derakon]

One of the things that bugs me about Angband is how, for purposes of getting around town, players are encouraged to kill townspeople just so they don't disturb running. Thus, I've written up a simple patch to add a new option "Disturb whenever townspeople move". It overrides the disturb_move and disturb_near options, but only when the monster's level is 0; thus, turning it off causes townspeople to no longer disturb you, but has no effect on other monsters.

I've tested this and it works, but the boolean logic involved gets a bit hairy, so I'd appreciate it if someone were to double-check that I haven't screwed things up. Also, for the sake of keeping the movement-related disturbance options together, I inserted this option between "disturb whenever viewable monster moves" and "disturb whenever leaving trap detected area", which means that disturb_detect and disturb_state have been moved down 1 in the options. This doesn't exactly break savefile compatibility but does mean that moving to this patch may cause your options to be wrong.

[Magnate]

Hmm. Sangband defaults to this behaviour and I really don't like it. ... which is of course precisely why you've coded it as an option, so fair enough. My last foray into the options menu was a disaster, but I'll have a look at applying this.

[takkaria]

One of the things that bugs me about Angband is how, for purposes of getting around town, players are encouraged to kill townspeople just so they don't disturb running. Thus, I've written up a simple patch to add a new option "Disturb whenever townspeople move". It overrides the disturb_move and disturb_near options, but only when the monster's level is 0; thus, turning it off causes townspeople to no longer disturb you, but has no effect on other monsters.

I've tested this and it works, but the boolean logic involved gets a bit hairy, so I'd appreciate it if someone were to double-check that I haven't screwed things up. Also, for the sake of keeping the movement-related disturbance options together, I inserted this option between "disturb whenever viewable monster moves" and "disturb whenever leaving trap detected area", which means that disturb_detect and disturb_state have been moved down 1 in the options. This doesn't exactly break savefile compatibility but does mean that moving to this patch may cause your options to be wrong.

There are 256-odd option slots (most of them empty) so you don't have to break savefile compatibility....

You should also remove one of the OPT_NONE from option_page when you add a new option, or there's one too many options in that array.

[Magnate]

There are 256-odd option slots (most of them empty) so you don't have to break savefile compatibility....

You should also remove one of the OPT_NONE from option_page when you add a new option, or there's one too many options in that array.

I just applied his patch and fixed that warning ...

[Derakon]

I rearranged the options because I thought it a bit odd to have the list in option.h not be in the same order as the list in option.c, but fair enough. Fixing the rearrangement is trivial in any event.

Thanks for the correction on the OPT_NONE bit. My mistake.

[Timo Pietilä]

One of the things that bugs me about Angband is how, for purposes of getting around town, players are encouraged to kill townspeople just so they don't disturb running. Thus, I've written up a simple patch to add a new option "Disturb whenever townspeople move". It overrides the disturb_move and disturb_near options, but only when the monster's level is 0; thus, turning it off causes townspeople to no longer disturb you, but has no effect on other monsters.

Is it possible to make a option to just generally remove disturbance from monsters that are fleeing from you because of level difference? That way you can use it entire game, not just after your level is high enough that townsfolk doesn't matter anymore. You could even sleep in room with orcs.

I'm not entirely sure what happens if monster that is fleeing from you (because of level difference) gets into dead end, but is not close enough to turn to fight. If it has distance attacks will it use them? Does fleeing black orc shoot missiles? I don't think it will, but I'm not sure.

[Magnate]

I rearranged the options because I thought it a bit odd to have the list in option.h not be in the same order as the list in option.c, but fair enough. Fixing the rearrangement is trivial in any event.

Thanks for the correction on the OPT_NONE bit. My mistake.

Well, I fixed that and pushed it to github as http://github.com/magnate/angband/tree/misc. So anyone who can clone and compile it can now try it for themselves ... if people like it I'll push it to the official repo (which should then get it into the nightly builds).