Morgoth Broken Again

[Gordon]

Killed Morgoth with arrows! Never had to hit him with my weapon once. He only hit me twice and knocked me down less than 200 HP. Unfortunately, all he dropped was a Massive Iron Crown [0,+4] 2.0 lb and a Mighty Hammer (3d9) (+2,+1) 20 lb. Neither had any special abilities.

[Gordon]

Character Dump

Here's the dump:

http://angband.oook.cz/ladder-show.php?id=9806

Notice items v) and w) in the Character Inventory.

[Magnate]

Here's the dump:

http://angband.oook.cz/ladder-show.php?id=9806

Notice items v) and w) in the Character Inventory.

This is a long-standing bug: http://trac.rephial.org/ticket/641. Nobody's yet been able to figure out why it happens.

[Marble Dice]

Based on comments in monster2.c, the codebase seems to assume that apply_magic() will turn the INSTA_ART base items into the necessary artifacts, but this is certainly not the case. Has this bug really been around that long?

[konijn_]

Based on comments in monster2.c, the codebase seems to assume that apply_magic() will turn the INSTA_ART base items into the necessary artifacts, but this is certainly not the case. Has this bug really been around that long?

I wonder if setting the name1 will just fix it ?

Angband

2918	                /* Mega-Hack -- Prepare to make "Grond" */
2919	                object_prep(i_ptr, lookup_kind(TV_HAFTED, SV_GROND), 0, MAXIMISE);
2920	
2921	                /* Note -- We must not set name1 so that it can be made into
2922	                 * an artifact by apply_magic */
2923	
2924	                /* Mega-Hack -- Actually create "Grond" */
2925	                apply_magic(i_ptr, -1, TRUE, TRUE, TRUE);

Hellband

/* Get local object */
q_ptr = &forge;
/* Mega-Hack -- Prepare to make "Crown of the Universe" */
object_prep(q_ptr, lookup_kind(TV_CROWN, SV_SEVENTH));
/* Mega-Hack -- Mark this item as "Crown of the Universe" */
q_ptr->name1 = ART_SEVENTH;
/* Mega-Hack -- Actually create "Crown of the Universe" */
apply_magic(q_ptr, -1, TRUE, TRUE, TRUE);
/* Drop it in the dungeon */
drop_near(q_ptr, -1, y, x);

[Marble Dice]

I wonder if setting the name1 will just fix it ?

I'm guessing that's how it used to work, but at some point, changes were made to Vanilla's apply_magic() or make_artifact() which prevented them from upgrading the items properly. It's possible it was even fixed for a time under the assumption that you don't set name1 and they got upgraded some other way, but then that got broken too.

r1892 has a fix which doesn't yet seem to break anything else, so here's hoping this one is gone for good now.