deep descent bug 3.1.2 dev r1886

[Tatami]

The scrolls only take you down to level 2.

This is my punishment for using them to go down to and past 127 to fetch the One before killing M I assume.

[d_m]

Did that actually work previously?

[Marble Dice]

This is an intentional change, deep descent always takes you 2 floors below your current position, without skipping quest levels.

[Tatami]

Did that actually work previously?

Aye, I believe it was r1866. With recall sometimes putting you on down stairs you could in fact go deeper than level 127.

[Nightmarjoo]

Couldn't it take you deeper before? Why the change?

[Marble Dice]

Couldn't it take you deeper before? Why the change?

The description used to read "two or three floors" even though it only took you 2 floors below the maximum. I'm not sure if it ever really did 1+1d2 or if the description just said it did.

[d_m]

So, I do think that !DD should work as it does now, but use max-depth instead of current-depth to figure out what depth you should go to.

At one point I think I said something like "should work like teleport level but always takes you down to depth + 2" and I may have been ambiguous, but I think it should be maxdepth + 2.

Does that seem crazy? It's a trivial patch to change it, but since it was just changed I don't want to change it back without a discussion.

[Marble Dice]

So, I do think that !DD should work as it does now, but use max-depth instead of current-depth to figure out what depth you should go to.

Fine with me either way, but the original ticket as Takkaria phrased it was "deep descent has wrong behavior at non-recall depth," and the ticket description specifically calls out the max_depth+2 behavior.

[Magnate]

Fine with me either way, but the original ticket as Takkaria phrased it was "deep descent has wrong behavior at non-recall depth," and the ticket description specifically calls out the max_depth+2 behavior.

Looking back, I'm not really sure why Takk thought that was wrong. The issue we were originally concerned with was reading ?DD in town, IIRC.

But whatever, he decided quite firmly that ?DD is the cousin of ?tlev and not of ?WoR, so it makes sense that maxdepth doesn't come into it.

[d_m]

Huh. I had thought the issue was whether to set (or cancel) the recall flag, and whether there should be a delay (like recall) when in town. I think that bug was opened after the discussion on IRC, but I don't really remember.

Anyway, on some level the current behavior is fine--I will just have to get used to reading WoR before DD.

[Marble Dice]

Takkaria first opened the ticket which cited only the max_depth issue. I took ownership of it, then started a discussion on IRC which you remember. Takkaria gave his opinion on the recall issue the next day on the IRC server.

Maybe you had some discussion before that which I wasn't part of, but that's the whole chronology as I know it.

[Nightmarjoo]

I like deep diving going to max depth + 2 (I wouldn't mind it being a range instead with chance of going deeper, but 2 works), but I don't like having to wait for a charge in town. My first winner, my warrior, was able to dive very very quickly thanks to the bm regularly supplying stacks of deep dive, and it was really fun. I liked being able to not waste recalls to go back down, and saving time looking for downstaircases at the same time.

[Nemesis]

I agree, Deep Descent is a great addition to the game as it can be very useful if used with caution and very dangerous if used without care! I remember when I was already "in to deep" and had been sneaking around way too dangerous monsters to find some nice loot. I had some unidentified scrolls and to save room, I took the risk of reading them. Despite reading "Trap Creation" and "Aggrevate Monsters" by accident I came home safely in the end. There, in town, I identified the final scroll that I hadn't read. That was Deep Descent! That could have taken my life, as I had no WoR and suffered a -3 speed penalty by having a couple of chests in my backpack!

[Derakon]

Apropos: why were you carrying chests? It seems unlikely that they would generate more than 1 item that you'd want to keep, and they're almost always going to be heavier than their contents.

[Nemesis]

Apropos: why were you carrying chests? It seems unlikely that they would generate more than 1 item that you'd want to keep, and they're almost always going to be heavier than their contents.

I'm used to playing Quickband (a variant based on NPP), where chests usually contained four things (many of them goodies).

When the chests in Vanilla didn't give as many nice things as the chests in Quickband I figured it was just because it was so early in the game (I'm playing Vanilla for the first time now and I've only reached dlvl 20) and that better chests content was to show up later.

By the way, are more chests generated when your dlvl is greater than your clvl? Are chest a reward for divers or is it just easier to remember the chests you have to avoid OOD monsters to get to?

EDIT: Only reached dlvl 20, not dlvl 2!