svn-1452 bug: wielding morning star firestar wants to target

[d_m]

Trying to wield Firestar seems like it wants to target. Firestar does have an activated ability for fire bolt... maybe it's getting confused?

I will try to debug this but just wanted to post about it first.

[d_m]

If I choose a direction, then it does let me wield. But without a direction it won't do it (although it helpfully takes off my previous weapon).

[d_m]

Also, using a staff of speed gives me a gruesome software bug (with panic save). This is turning into my bug thread, apparently.

It's too bad, because I really need to use the staff of speed

[ChodTheWacko]

Also, using a staff of speed gives me a gruesome software bug (with panic save). This is turning into my bug thread, apparently.

It's too bad, because I really need to use the staff of speed

For me, it happens for a staff of identify, and it happens starting with revision 1448.

- Frank

[d_m]

Yeah, I think all staves are busted right now.

[d_m]

So I figured out the problem and sent a patch to the list. Hopefully it will get committed soon!

EDIT: committed! update to 1454!

Here is the patch inline if you want to apply it yourself:

Index: src/game-cmd.c
===================================================================
--- src/game-cmd.c      (revision 1452)
+++ src/game-cmd.c      (working copy)
@@ -89,7 +89,7 @@
        { CMD_EAT, { arg_ITEM, arg_END }, do_cmd_use, FALSE },
        { CMD_QUAFF, { arg_ITEM, arg_TARGET, arg_END }, do_cmd_use, FALSE },
        { CMD_USE_ROD, { arg_ITEM, arg_TARGET, arg_END }, do_cmd_use, FALSE },
-       { CMD_USE_STAFF, { arg_ITEM }, do_cmd_use, FALSE },
+       { CMD_USE_STAFF, { arg_ITEM, arg_END }, do_cmd_use, FALSE },
        { CMD_USE_WAND, { arg_ITEM, arg_TARGET, arg_END }, do_cmd_use, FALSE },
        { CMD_READ_SCROLL, { arg_ITEM, arg_TARGET, arg_END }, do_cmd_use, FALSE },
        { CMD_ACTIVATE, { arg_ITEM, arg_TARGET, arg_END }, do_cmd_use, FALSE },

[Pete Mack]

Looks like the C-style object oriented code is proceding apace!
All those pretty function pointers... I can tell that ajps has been hard at work.