bug: monster list r1418

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • bebo
    Adept
    • Jan 2009
    • 213

    bug: monster list r1418

    First of all I would like to say that the new improvements to the monster list are great (thanks magnate), being able to know which monsters are asleep and if they have los is really useful.

    Just one suggestion, it might improve readability if a blank line would be put between the two groups.

    Anyways, it seems like the (asleep) descriptor is a bit broken - namely i hit a monster that was asleep, it woke up and started running away but still appeared as sleeping in the monster list. Savefile attached.
    Attached Files
    My first winner! http://angband.oook.cz/ladder-show.php?id=8681
    And my second! http://angband.oook.cz/ladder-show.php?id=8872
    And the third! http://angband.oook.cz/ladder-show.php?id=9452
    And the fourth! http://angband.oook.cz/ladder-show.php?id=10513
    And the fifth! http://angband.oook.cz/ladder-show.php?id=10631
    And the sixth! http://angband.oook.cz/ladder-show.php?id=10990
  • Magnate
    Angband Devteam member
    • May 2007
    • 5110

    #2
    Originally posted by bebo
    First of all I would like to say that the new improvements to the monster list are great (thanks magnate), being able to know which monsters are asleep and if they have los is really useful.

    Just one suggestion, it might improve readability if a blank line would be put between the two groups.
    I thought about that, but I figured space was at a premium (my monster list window is tiny). Especially as most of the time (i.e. without ESP or casting Detect Something), the last line is "You are aware of 0 other monsters."
    Anyways, it seems like the (asleep) descriptor is a bit broken - namely i hit a monster that was asleep, it woke up and started running away but still appeared as sleeping in the monster list. Savefile attached.
    Ah, thank you. I suspect this is to do with how/when the list is refreshed, rather than with the new list code itself (though it is always possible that m_ptr->csleep is not being updated). I'll look into it tonight.
    "Been away so long I hardly knew the place, gee it's good to be back home" - The Beatles

    Comment

    • bebo
      Adept
      • Jan 2009
      • 213

      #3
      Originally posted by Magnate
      I thought about that, but I figured space was at a premium (my monster list window is tiny). Especially as most of the time (i.e. without ESP or casting Detect Something), the last line is "You are aware of 0 other monsters."
      You're right - maybe like suggested in the other thread simply not displaying the line "You are aware of 0 other monsters." (of course only when it's 0) is the most elegant solution?
      My first winner! http://angband.oook.cz/ladder-show.php?id=8681
      And my second! http://angband.oook.cz/ladder-show.php?id=8872
      And the third! http://angband.oook.cz/ladder-show.php?id=9452
      And the fourth! http://angband.oook.cz/ladder-show.php?id=10513
      And the fifth! http://angband.oook.cz/ladder-show.php?id=10631
      And the sixth! http://angband.oook.cz/ladder-show.php?id=10990

      Comment

      • Magnate
        Angband Devteam member
        • May 2007
        • 5110

        #4
        Originally posted by bebo
        You're right - maybe like suggested in the other thread simply not displaying the line "You are aware of 0 other monsters." (of course only when it's 0) is the most elegant solution?
        Yes, I think I agree with that. Fixed in r1425.
        Last edited by Magnate; June 1, 2009, 20:04.
        "Been away so long I hardly knew the place, gee it's good to be back home" - The Beatles

        Comment

        • Magnate
          Angband Devteam member
          • May 2007
          • 5110

          #5
          Originally posted by Magnate
          I suspect this is to do with how/when the list is refreshed, rather than with the new list code itself (though it is always possible that m_ptr->csleep is not being updated). I'll look into it tonight.
          Fixed in r1440.
          "Been away so long I hardly knew the place, gee it's good to be back home" - The Beatles

          Comment

          Working...
          😀
          😂
          🥰
          😘
          🤢
          😎
          😞
          😡
          👍
          👎