r1264 bug: crash at prompt (Windows)

[Colbey]

In playing r1264 in Windows (from the nightly build), I destroyed 2 of a stack of 4 books in my inventory, and then pressed Enter to "Ignore this book in the future? [y/n]" The game immediately crashed at that point.

Pressing "n" crashes it as well.

[CunningGabe]

Could you post a savefile? I'm having trouble reproducing this bug on my own.

[Colbey]

Sure. (Attached file is a raw savefile, not a zip file. I added the extension to the filename to get around the forum upload restrictions.)

[CunningGabe]

It seems to work okay for me -- does it crash for any book? Which one in particular did you destroy?

[Colbey]

One of the 3 Chants and Blessings.

[CunningGabe]

Still working fine for me. How did the game crash -- did it hang? Suddenly exit with no warning? Exit with a warning?

Do you not get the crash with other prayer books?

[Colbey]

Windows told me that angband.exe encountered a problem and needs to close. It has this "Error signature":

AppName: angband.exe AppVer: 0.0.0.0 ModName: angband.exe
ModVer: 0.0.0.0 Offset: 00045f4a

I can also view a large hexdump through the Windows error screens, but I can't seem to save or copy the dump. (Not shocked at that level of uselessness coming from Windows...)

It also crashed on the Words Of Wisdom (tried destroying all this time, on the theory that the issue triggers when destroying some but not all of a stack), but not when destroying my only Potion of Speed. (I don't remember how many !speeds are in the dump above, but I've been playing since and only had 1 left.)

[CunningGabe]

Hmm. There was another person who was having book-squelch troubles as well, but as far as I know, nothing else has had a problem. Which version of Windows are you running? (I'm guessing Vista?)

I have a hunch what may be causing this -- there's an sval name buffer used to build the prompt, and the book svals names are far longer than anything else. I think they're causing a buffer overflow somewhere. I've just committed a change in r1265 to enlarge the buffer; if this fixes the crashes, then I'll look into it a little more and make a less hackish fix.

(It sounds like you're not building from source, so you'll just have to wait a little for the next build.) Let me know if it's any better.

[Colbey]

Not Vista; XP SP3.

Thanks for checking in a fix! You're right that I'm not building from source, and I often don't get a chance to play over the weekend, but I'll try to verify the fix next week. (Other people, obviously, feel free to download the savefile if you want to look at this bug.)

[bebo]

see http://angband.oook.cz/forum/showthread.php?t=1477 also

[CunningGabe]

bebo, can you try the latest nightly (r1266) and tell me if you still get the crash?

[bebo]

i don't