Borg bugs and feature requests

[backwardsEric]

Can you get me the save file that crashes? Best to wrap in angband.ini and borg.txt if you can.

For the macOS front end, the equivalent to angband.ini would be the output from running

defaults read org.rephial.angband

in a terminal.

[agoodman]

Anyone know if any of these crashes may have been fixed in 4.2.6-216?

Edit: tried out the new version. Gets to town (apparently has save on changing level on, which is good), crashes (wasn't paying attention at the time...), reopened, I turn on borg again, crashes again before I can say mouse...

Can you get me the save file that crashes? Best to wrap in angband.ini and borg.txt if you can.

https://github.com/angband/angband/r...216-g1d2ad35a2 should have most of the fixes but resurrection is still being worked on. There are a couple of more issues coming but I wouldn't think we would have crashes that fast right now.

[eschiss1]

Anyone know if any of these crashes may have been fixed in 4.2.6-216?

Edit: tried out the new version. Gets to town (apparently has save on changing level on, which is good), crashes (wasn't paying attention at the time...), reopened, I turn on borg again, crashes again before I can say mouse...

[agoodman]

those detection arrays are going to be the death of me. I am going to add some debugging around them and try to track down what is going on.

[backwardsEric]

Thanks for that. Looking at the disassembly (_borg_launch_bolt starts at 10011daf0, 1214 (decimal) past that puts it at 10011dfae, "cmpb $0x0, (%rax,%rdi)"), the crash happened at borg-fight-attack.c:1577 ("&& !borg_detect_wall[q_y + 1][q_x + 0]"). That's not similar to any of the problems I've run into recently, but the handling of borg_detect_walls changed in 4.2.6-177.

[eschiss1]

And a longer excerpt

[eschiss1]

Ah, I was looking at a different kind of crash report, but the kind you mean is easily found in Console. Here's the thread 0 information from one such crash:

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 angband 0x103618fae borg_launch_bolt + 1214
1 angband 0x103619592 borg_attack_aux_launch + 386
2 angband 0x10361ec48 borg_attack + 1016
3 angband 0x1036669a5 borg_think_dungeon + 2069
4 angband 0x1036699b2 borg_think + 818
5 angband 0x1036772f4 borg_entry_point + 788
6 angband 0x1035dacf0 inkey_ex + 256
7 angband 0x1035dd211 textui_get_command + 193
8 angband 0x1035d85aa textui_process_command + 26
9 angband 0x1035d890e textui_get_cmd + 14
10 angband 0x1035d90f6 play_game + 1862
11 angband 0x103506078 -[AngbandAppDelegate beginGame] + 2984
12 angband 0x1035082a6 -[AngbandAppDelegate applicationDidFinishLaunching:] + 102
13 CoreFoundation 0x7ff809c3e47c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERV ER__ + 137
14 CoreFoundation 0x7ff809cc9bc2 ___CFXRegistrationPost_block_invoke + 88
15 CoreFoundation 0x7ff809cc9b17 _CFXRegistrationPost + 515
16 CoreFoundation 0x7ff809c0e8cb _CFXNotificationPost + 763
17 Foundation 0x7ff80ad3b0fd -[NSNotificationCenter postNotificationNamebject:userInfo:] + 82
18 AppKit 0x7ff80d6b7342 -[NSApplication _postDidFinishNotification] + 311
19 AppKit 0x7ff80d6b708b -[NSApplication _sendFinishLaunchingNotification] + 215
20 AppKit 0x7ff80d6b5129 -[NSApplication(NSAppleEventHandling) _handleAEOpenEvent:] + 546
21 AppKit 0x7ff80d6b4d79 -[NSApplication(NSAppleEventHandling) _handleCoreEvent:withReplyEvent:] + 679
22 Foundation 0x7ff80ad63c91 -[NSAppleEventManager dispatchRawAppleEvent:withRawReply:handlerRefCon:] + 307
23 Foundation 0x7ff80ad63aa5 _NSAppleEventManagerGenericHandler + 80
24 AE 0x7ff8114ccd6e 0x7ff8114c2000 + 44398
25 AE 0x7ff8114cc5d1 0x7ff8114c2000 + 42449
26 AE 0x7ff8114c5ed6 aeProcessAppleEvent + 409
27 HIToolbox 0x7ff8156a4095 AEProcessAppleEvent + 55
28 AppKit 0x7ff80d6ae0f2 _DPSNextEvent + 1729
29 AppKit 0x7ff80e13bc17 -[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:deque ue:] + 1263
30 AppKit 0x7ff80d69eea9 -[NSApplication run] + 610
31 AppKit 0x7ff80d672005 NSApplicationMain + 803
32 angband 0x1035089f9 main + 9
33 dyld

[backwardsEric]

This is from macOS 26.6.1 on an ARM system, so the layout may be different than yours. The most useful part of the crash report would be the part near the start starting with "Triggered by Thread " and continuing through the state of the threads. If you want to cut it down further, the information on thread 0 is the most useful. Here is an example (the details will be different than yours as this was generated by inserting a "kill(getpid(), SIGBUS)" into the code shortly after the macOS front end starts):

Triggered by Thread: 0, Dispatch Queue: com.apple.main-thread

Exception Type:    EXC_CRASH (SIGABRT)
Exception Codes:   0x0000000000000000, 0x0000000000000000

Termination Reason:  Namespace SIGNAL, Code 6, Abort trap: 6
Terminating Process: angband [88758]


Application Specific Information:
abort() called


Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib                   0x1896805e8 __pthread_kill + 8
1   libsystem_pthread.dylib                  0x1896bb8d8 pthread_kill + 296
2   libsystem_c.dylib                        0x1895c1978 abort + 148
3   libclang_rt.asan_osx_dynamic.dylib           0x103f00254 __sanitizer::Abort() + 84
4   libclang_rt.asan_osx_dynamic.dylib           0x103eff84c __sanitizer::Die() + 108
5   libclang_rt.asan_osx_dynamic.dylib           0x103ee0eb0 __asan::ScopedInErrorReport::~ScopedInErrorReport() + 1392
6   libclang_rt.asan_osx_dynamic.dylib           0x103ede2f0 __asan::ReportDeadlySignal(__sanitizer::SignalContext const&) + 152
7   libclang_rt.asan_osx_dynamic.dylib           0x103edd78c __asan::AsanOnDeadlySignal(int, void*, void*) + 112
8   libsystem_platform.dylib                 0x1896c5744 _sigtramp + 56
9   angband                                  0x102700e68 -[AngbandAppDelegate beginGame] + 296 (main-cocoa.m:5836)
10  angband                                  0x102705ca4 -[AngbandAppDelegate applicationDidFinishLaunching:] + 120 (main-cocoa.m:6250)
11  CoreFoundation                           0x18976d9bc __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 148
12  CoreFoundation                           0x1897fa08c ___CFXRegistrationPost_block_invoke + 92
13  CoreFoundation                           0x1897f9fd0 _CFXRegistrationPost + 440
14  CoreFoundation                           0x18973c3d8 _CFXNotificationPost + 740
15  Foundation                               0x18af734a4 -[NSNotificationCenter postNotificationName:object:userInfo:] + 88
16  AppKit                                   0x18dbb65e8 -[NSApplication _postDidFinishNotification] + 308
17  AppKit                                   0x18dbb6380 -[NSApplication _sendFinishLaunchingNotification] + 172
18  AppKit                                   0x18dbb49c4 -[NSApplication(NSAppleEventHandling) _handleAEOpenEvent:] + 488
19  AppKit                                   0x18dbb45d8 -[NSApplication(NSAppleEventHandling) _handleCoreEvent:withReplyEvent:] + 488
20  Foundation                               0x18af9bfbc -[NSAppleEventManager dispatchRawAppleEvent:withRawReply:handlerRefCon:] + 316
21  Foundation                               0x18af9bdb4 _NSAppleEventManagerGenericHandler + 80
22  AE                                       0x1919aef34 0x1919a4000 + 44852
23  AE                                       0x1919ae88c 0x1919a4000 + 43148
24  AE                                       0x1919a7fb8 aeProcessAppleEvent + 484
25  HIToolbox                                0x1964bc344 AEProcessAppleEvent + 68
26  AppKit                                   0x18dbae348 _DPSNextEvent + 1284
27  AppKit                                   0x18e74396c -[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 688
28  AppKit                                   0x18e743678 -[NSApplication(NSEventRouting) nextEventMatchingMask:untilDate:inMode:dequeue:] + 72
29  AppKit                                   0x18dba113c -[NSApplication run] + 368
30  AppKit                                   0x18db797b0 NSApplicationMain + 880
31  angband                                  0x1027067d8 main + 12 (main-cocoa.m:6416)
32  dyld                                     0x1892f04e4 start + 6992

Thread 1:

Thread 2:

Thread 3:: com.apple.NSEventThread
0   libsystem_kernel.dylib                   0x189677c34 mach_msg2_trap + 8
1   libsystem_kernel.dylib                   0x18968a5a4 mach_msg2_internal + 76
2   libsystem_kernel.dylib                   0x1896809c0 mach_msg_overwrite + 480
3   libsystem_kernel.dylib                   0x189677fc0 mach_msg + 24
4   CoreFoundation                           0x1897790d8 __CFRunLoopServiceMachPort + 160
5   CoreFoundation                           0x1897779c4 __CFRunLoopRun + 1188
6   CoreFoundation                           0x18984a234 _CFRunLoopRunSpecificWithOptions + 532
7   AppKit                                   0x18dccfcac _NSEventThread + 184
8   libclang_rt.asan_osx_dynamic.dylib           0x103ed5d68 asan_thread_start(void*) + 80
9   libsystem_pthread.dylib                  0x1896bbc58 _pthread_start + 136
10  libsystem_pthread.dylib                  0x1896b6c1c thread_start + 8

Thread 4:


Thread 0 crashed with ARM Thread State (64-bit):
    x0: 0x0000000000000000   x1: 0x0000000000000000   x2: 0x0000000000000000   x3: 0x0000000000000000
    x4: 0x0000000000000000   x5: 0x0000000000000000   x6: 0x0000000000000000   x7: 0x0000000000000000
    x8: 0x166679e19e38d4bb   x9: 0x166679e06837753b  x10: 0x00000070206e95e7  x11: 0x00000000206c95e7
   x12: 0x00000000206c95e7  x13: 0x0000000000000000  x14: 0x0000000000000000  x15: 0x0000000000000000
   x16: 0x0000000000000148  x17: 0x00000001f773b400  x18: 0x0000000000000000  x19: 0x0000000000000006
   x20: 0x0000000000000103  x21: 0x00000001f60fa260  x22: 0x0000000105136548  x23: 0x0000000103f5b900
   x24: 0x0000000103f5b000  x25: 0x0000000000000000  x26: 0x000000016d7212e0  x27: 0x000000702db0425c
   x28: 0x0000000000000000   fp: 0x000000010364af10   lr: 0x00000001896bb8d8
    sp: 0x000000010364aef0   pc: 0x00000001896805e8 cpsr: 0x40001000
   far: 0x0000000000000000  esr: 0x56000080 (Syscall)

[eschiss1]

May not be the same kind of crash report- tried searching for stack and also for call, and nothing looked like call stack, callstack or call_stack (though "\nstack" , "STACK GUARD" and some others were present?)

[backwardsEric]

It would be useful to see the crash data file (if there's a part with the call stack at the point of the crash, that would be the most useful part). Without more information, I would guess the crash has the same cause as https://github.com/agoodman00/angband/issues/43 . That happens after the borg recalls to town and is triggered by changes in 4.2.6-177-g5da31305a.

[eschiss1]

Downloaded 4.2.6-203-g167ba295d-osx.dmg to my 2019 iMac running Sequoia 15.8. Crashes well within a minute after starting the borg - may be because I did something funky with the included borg.txt file (I replaced the built-in borg.txt file with it, thinking this is what one was supposed to do. It occurs to me now that was not what I was supposed to do and that the included borg.txt file is meant to be cut-and-pasted into several sections of the existing borg.txt file... hrm. I vaguely remember something like this from an earlier version- help?) (4.2.6-173, which I still have, launches after the crash and works fine, which eliminates some kinds of bugs...)
Edit: can upload the crash data file provided by my Mac (after dividing it into two parts).

[eschiss1]

4.2.6-149: I assume DOS refers to MS-DOS and similar, not Dine-of-Sight (darn those hungry monsters)

[eschiss1]

Thanks much - also Eric

[backwardsEric]

https://github.com/angband/angband/r...120-gcebb5ffc9 , which fixes the hang noted by eschiss1 , is available.

[eschiss1]

Thanks, ok, that works.