Well then it's a win-win for everybody - takk is much more likely to get round to looking at it when it's on github and all the conflicts are easy to see.
I remember you tried before, and I also was pretty busy at the time. It's great that you're willing to try again - I'm really happy to help. Best would be to drop in on #angband-dev at irc.freenode.net if you can - even if I'm afk someone else should be able to help. Otherwise PM me and we can exchange IM details.
Just off the top of my head, the sequence is:
1. Get a github account and log in.
2. Go to http://github.com/angband/angband and click the Fork button.
3. On your command line, type "git clone http://github.com/myaccount/angband.git"
But if it gets messy, let's talk it through.
When it comes to Vanilla Angband, who does what for the game?
Collapse
X
-
No, I don't mind it. I tried to set one up several months ago. But I don't think it worked correctly and I had a horrible time trying to find the time to teach myself the command line stuff for properly uploading the changes. If there were some more simple execution commands, or a GUI, or a macro.Hi Andrew - I'm very keen to get a better handle on the Borg code, because I think it could really help us with finding and fixing bugs in the dev versions - but to do that it we would need to maintain a "borg" branch on github for continual updating and testing. Would you consider publishing the borg on github so we could do that? We wouldn't expect you to keep up-to-date with every dev version (but help would obviously be much appreciated!).
You guys did a nice job with the thread ("trying to git get" or something like that). But at the time, I was working +70 hours a week setting up my new practice. Now I am only working +55 hours, so I could revisit the issue.
It would be a lot easier if one of you guys walked me through the process of setting up the proper branch, or did it for me.
It looks like I have gitBash and GitGUI on my machine, but I didn't ever get GitGUI to work correctly and always ended up with command line coding (Git Bash). As I recall, it was a problem with verifying the repository or something. I seemed like such a mess.
The other problem is the borg330. It does not work due to some changes in how the inkey() works. Tak was supposed to take a look at it, but he hasn't gotten around to it.Leave a comment:
-
I'm not part of the dev team. Hell, I don't even play Vanilla. I'm one of the guys who has fond childhood memories of brutal, unforgiving rogue-likes and tries to take the maintainers to the woodshed whenever I feel they're about to step in it, that is, taking the game away from it's historical roots (into variant territory) or trying to force it to have a kind heart. I feel I've largely failed at my task, and have all but given up on trying to "Save Vanilla".Leave a comment:
-
Hi Andrew - I'm very keen to get a better handle on the Borg code, because I think it could really help us with finding and fixing bugs in the dev versions - but to do that it we would need to maintain a "borg" branch on github for continual updating and testing. Would you consider publishing the borg on github so we could do that? We wouldn't expect you to keep up-to-date with every dev version (but help would obviously be much appreciated!).I maintain the code for the borg, which is a screensaver version and automatic player. The borg will play the game and you get to watch it. There are some configuration files that allow you to exert some influence on how the borg plays. The borg source and executable files can be found here. I work on the borg nearly daily, and make updates a couple times a week.
Most of what I do is try to keep the borg up to date with the changes to the game code as it goes through development. I add new features and change the AI a bit as I go along.Leave a comment:
-
I maintain the code for the borg, which is a screensaver version and automatic player. The borg will play the game and you get to watch it. There are some configuration files that allow you to exert some influence on how the borg plays. The borg source and executable files can be found here. I work on the borg nearly daily, and make updates a couple times a week.
Most of what I do is try to keep the borg up to date with the changes to the game code as it goes through development. I add new features and change the AI a bit as I go along.Leave a comment:
-
This programmer has so far solved three tickets. The most visible thing I have done was to enable the player to lock doors with the disarm command. I'm looking for the very simplest issues to solve, and there are a couple of things I'm examining now.Leave a comment:
-
I am one of the angband developers with push access to Github.
I seem to do a lot of random bugfixes, integrating other people's work, etc. My own interests are somewhat scattered, although dungeon generation is something I'm always interested in.Last edited by d_m; September 28, 2011, 20:06.Leave a comment:
-
Yeah, that sounds good.@ d_m : "more interesting consumables" copy+pasted from magnates link above here, is there anything specific you'd like to see? I take it that you mean food/drink? Should I give it an hour and see what kind of tile edibles I can come up with and we'll take it from there?
Basically, my plan was to remove satisfy hunger spells/scrolls, make more varieties of food with varying amounts of nutrition and possibly side bonuses. For instance, before Takkaria removed restore potions I was thinking of a particular food that restores a kind of stat (so maybe Apples restore dexterity or something).
I mostly wanted to experiment to see how interesting food/drink could be made, and if it was worth it.Leave a comment:
-
I'm the developer-in-chief, I've been in this role for about four and a half years... my main goals were not having the game and its community die, and improving the UI. Thesedays, I spend more time doing code review, occasionally filing tickets and making tweaks. I still have a lot of interest in fixing up the UI, but I haven't got as much time to spend on the game anymore.Leave a comment:
-
Agreed. I wish it were that simple. Between the 4gai project functions and 4gai cave[][] array, the UnAngband terrrain system, and all the other changes we made, the NPP and Vanilla code bases are more different than similar at this point. Outside of the z-*.c files and the main*.c files, it is a real challenge to find a function that we haven't modified in some way.Yes, it would. But it's better practice to try and incorporate the actual commits and re-use the work, than to make a diff and try and apply it yourself. But I fully understand that NPP is quite different and it might actually be less work to create the diff and start from there. So whatever works for you really.
But I promise, next time I do a patch for Vanilla I will fork the repository, upload a commit & push it to Angband for you all to accept.Leave a comment:
-
Yes, it would. But it's better practice to try and incorporate the actual commits and re-use the work, than to make a diff and try and apply it yourself. But I fully understand that NPP is quite different and it might actually be less work to create the diff and start from there. So whatever works for you really.::::dumb github question alert::::
It loosk like all of the x-char removal was pushed to the master branch on Sept 20. If I look at all those commits, or did a gif of before and after on that date, wouldn't that give me a good idea of all the changes that need to be made?Leave a comment:
-
::::dumb github question alert::::I had forgotten that you fixed the Windows build. I tend to think that once things get merged into master we don't need to keep feature branches up-to-date (indeed most of them disappear after merge) - I just thought it would be handy for Jeff to see all the work at a glance.
Jeff - d_m's Windows fixes are in commit 352d420 - if you merge from master you'll get that anyway, but if you merge from the pnd10-utf8 branch you'll need to cherry-pick it. (You'll also need fea238a which regenerates Makefile.inc ...)
It loosk like all of the x-char removal was pushed to the master branch on Sept 20. If I look at all those commits, or did a gif of before and after on that date, wouldn't that give me a good idea of all the changes that need to be made?Leave a comment:
-
I had forgotten that you fixed the Windows build. I tend to think that once things get merged into master we don't need to keep feature branches up-to-date (indeed most of them disappear after merge) - I just thought it would be handy for Jeff to see all the work at a glance.
Jeff - d_m's Windows fixes are in commit 352d420 - if you merge from master you'll get that anyway, but if you merge from the pnd10-utf8 branch you'll need to cherry-pick it. (You'll also need fea238a which regenerates Makefile.inc ...)Leave a comment:
-
@ d_m : "more interesting consumables" copy+pasted from magnates link above here, is there anything specific you'd like to see? I take it that you mean food/drink? Should I give it an hour and see what kind of tile edibles I can come up with and we'll take it from there?Leave a comment:
-
Oh, should I have submitted a pull request for the UTF8 issues I fixed to this branch?It's in the current dev versions, but if you want just the UTF8 stuff separate from the rest of the stuff in master, it's at http://github.com/pnd10/angband/tree/utf-8.
As of now, I think that branch won't build on Windows.Leave a comment:
Leave a comment: