p_ptr->class vs. p_ptr->pclass

[APWhite]

So what was the push to switch pclass to class? 'class' is a reserved word in some environments (like Visual Studio).

pclass was still a useful word. We understood it to be player-class. I think that switch may have caused more harm than good.

[d_m]

So what was the push to switch pclass to class? 'class' is a reserved word in some environments (like Visual Studio).

pclass was still a useful word. We understood it to be player-class. I think that switch may have caused more harm than good.

I didn't make the change, but absent other considerations i think player->class and p_ptr->class read better. That said, if it's breaking things then I'm not necessarily against changing it back.

Does this prevent you from building in VC++/VS? I think that BluBaron has been building recent staging in Angband in VS without hitting this problem.

[Blue Baron]

I didn't make the change, but absent other considerations i think player->class and p_ptr->class read better. That said, if it's breaking things then I'm not necessarily against changing it back.

Does this prevent you from building in VC++/VS? I think that BluBaron has been building recent staging in Angband in VS without hitting this problem.

I am building without any mention of this pointer. even though "class" is highlighted for me, I guess it is not treated as a keyword in C files.

[Derakon]

It may also be that since it isn't a bare word it doesn't confuse the parser.

[fph]

GTK uses "klass" instead of "class" to avoid conflicting with the C++ reserved word. This is funny to see, since "klass" sounds a lot like the typical KDE3 app name...

[Azerath]

klass - may come from KDE Large Ass... ;-) - just kidding no want to start OS-War ;-)