Tweet
In the current system for feature graphics, we have 3 char/attr pairs:
A 'dark' pair
A 'torchlit' pair
and a 'lit' pair
OK, so far so good.
But there is also special casing code that changes anything white into yellow if it is torchlit, or into grey if it is dark. Which sort of defeats the purpose of having customizable tiles for each lighting level. Most of cave.c/grid_get_text should probably be removed.
removing-colour-overrides.txt
The view_yellow_light option would need renaming to account for the torchlit tiles not necessarily being yellow anymore (actually they aren't necessarily yellow now- if you set the torchlit floor tile to be anything other than white or yellow)
We really could use torchlit floors being yellow by default here, unless we remove the view_yellow_light option as below.
If the view_yellow_light is not set, then anything torchlit will be displayed as lit instead. One could argue that this option is redundant, given the ability to explicitly set the torchlight grids to whatever you like, including exactly the same as regular lit grids. (I would say its probably premature to remove it yet, given the difficulty in editing feature graphics, but its on borrowed time)
A 'dark' pair
A 'torchlit' pair
and a 'lit' pair
OK, so far so good.
But there is also special casing code that changes anything white into yellow if it is torchlit, or into grey if it is dark. Which sort of defeats the purpose of having customizable tiles for each lighting level. Most of cave.c/grid_get_text should probably be removed.
removing-colour-overrides.txt
The view_yellow_light option would need renaming to account for the torchlit tiles not necessarily being yellow anymore (actually they aren't necessarily yellow now- if you set the torchlit floor tile to be anything other than white or yellow)
We really could use torchlit floors being yellow by default here, unless we remove the view_yellow_light option as below.
If the view_yellow_light is not set, then anything torchlit will be displayed as lit instead. One could argue that this option is redundant, given the ability to explicitly set the torchlight grids to whatever you like, including exactly the same as regular lit grids. (I would say its probably premature to remove it yet, given the difficulty in editing feature graphics, but its on borrowed time)
Comment