Inventory display bug

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • PowerWyrm
    Prophet
    • Apr 2008
    • 2986

    Inventory display bug

    If your character has missiles equipped in the quiver slot and nothing in the inventory, the inventory subwindow will display:

    (nothing)
    b) in Quiver: n missiles

    When using the "i" command, the "in Quiver" line is aligned to the right and out of the screen (because quiver slots are not processed when calculating max name length in show_obj_list).
    PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!
  • d_m
    Angband Devteam member
    • Aug 2008
    • 1517

    #2
    Originally posted by PowerWyrm
    If your character has missiles equipped in the quiver slot and nothing in the inventory, the inventory subwindow will display:

    (nothing)
    b) in Quiver: n missiles

    When using the "i" command, the "in Quiver" line is aligned to the right and out of the screen (because quiver slots are not processed when calculating max name length in show_obj_list).
    Thanks for catching these!

    Would you mind opening tickets in trac.rephial.org so we can easily see which ones are still outstanding and which ones aren't? It's easy to lose track of them on the forum.
    linux->xterm->screen->pmacs

    Comment

    • jens
      Swordsman
      • Apr 2011
      • 348

      #3
      Originally posted by d_m
      Thanks for catching these!

      Would you mind opening tickets in trac.rephial.org so we can easily see which ones are still outstanding and which ones aren't? It's easy to lose track of them on the forum.
      Is that a general advice? I mean, what I usually do is post an issue to the forum, then let one of you dev guys open a ticket if deemed worthy. Which sometimes leads to me getting ignored and frustrated, and having to keep track of the issues myself to repost later...

      Would it be better to open a ticket, then if deemed unworthy you close it? That way I would at least know that I was not ignored, just disagreed with, which is much better for me :-)

      Comment

      • PowerWyrm
        Prophet
        • Apr 2008
        • 2986

        #4
        Done. It's now ticket #1465.
        PWMAngband variant maintainer - check https://github.com/draconisPW/PWMAngband (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!

        Comment

        • Max Stats
          Swordsman
          • Jun 2010
          • 324

          #5
          Originally posted by jens
          That way I would at least know that I was not ignored, just disagreed with, which is much better for me :-)
          Huh? Did someone say something?
          If beauty is in the eye of the beholder, then why are beholders so freaking ugly?

          Comment

          • Zyphyr
            Adept
            • Jan 2008
            • 135

            #6
            Originally posted by Max Stats
            Huh? Did someone say something?
            Nope. Completely empty thread here.

            Comment

            • d_m
              Angband Devteam member
              • Aug 2008
              • 1517

              #7
              Originally posted by jens
              Is that a general advice? I mean, what I usually do is post an issue to the forum, then let one of you dev guys open a ticket if deemed worthy. Which sometimes leads to me getting ignored and frustrated, and having to keep track of the issues myself to repost later...

              Would it be better to open a ticket, then if deemed unworthy you close it? That way I would at least know that I was not ignored, just disagreed with, which is much better for me :-)
              I like seeing forum posts about bugs, and for people who only report a few bugs, it's probably the easiest thing for them to do. But it's nice to also have people open Trac tickets...otherwise I (or someone else) has to remember to open the tickets, and then copy the bug description (or link to the post on oook). Which is fine, it's just nice when someone else does it. Ultimately Trac tickets are more useful because they have a unique ID # that we can use to talk about them, and we can run reports (to see how many bugs are outstanding, to figure out what we fixed since 3.2, to know who's working on what, etc).

              I only mentioned it because I know PowerWyrm has been posting about a number of issues (and also happens to be a developer!). I didn't want to miss/forget any of them.

              We are committed to fixing all bugs, no matter how they are reported!
              linux->xterm->screen->pmacs

              Comment

              • jens
                Swordsman
                • Apr 2011
                • 348

                #8
                So basically if I see a bug I can just as well open a ticket for it (after verifying it's not on trac already).

                But what if it's a grey area case, where things are working in ways I see as clearly inferior, but others might have another opinion? Then I guess opening a ticket must be done after some discussion. The problem is that if it is a minor issue often there is no discussion, or no resolution to the discussion, it just ends.

                Comment

                • Magnate
                  Angband Devteam member
                  • May 2007
                  • 5110

                  #9
                  Originally posted by jens
                  So basically if I see a bug I can just as well open a ticket for it (after verifying it's not on trac already).

                  But what if it's a grey area case, where things are working in ways I see as clearly inferior, but others might have another opinion? Then I guess opening a ticket must be done after some discussion. The problem is that if it is a minor issue often there is no discussion, or no resolution to the discussion, it just ends.
                  If you read http://trac.rephial.org/wiki/TicketCreation, you'll see the advice to open a ticket after your bug has been corroborated by somebody else on Oook: "Please do not open a ticket unless at least one other person can reproduce your bug". This way we will avoid a lot of non-bugs being opened on trac.
                  "Been away so long I hardly knew the place, gee it's good to be back home" - The Beatles

                  Comment

                  • jens
                    Swordsman
                    • Apr 2011
                    • 348

                    #10
                    OK, I'll keep hassling the forum until I get a response on an issue, then open a ticket ;-)

                    Comment

                    • Timo Pietilä
                      Prophet
                      • Apr 2007
                      • 4096

                      #11
                      Originally posted by jens
                      OK, I'll keep hassling the forum until I get a response on an issue, then open a ticket ;-)
                      Did you have some specific issue in mind?

                      Comment

                      • jens
                        Swordsman
                        • Apr 2011
                        • 348

                        #12
                        Originally posted by Timo Pietilä
                        Did you have some specific issue in mind?
                        Some time back I posted a bunch of issues in the same post, some got a ticket, some got a mention, some got ignored... Will repost those without a resolution in nice batches next week :-)

                        Comment

                        • Magnate
                          Angband Devteam member
                          • May 2007
                          • 5110

                          #13
                          Originally posted by jens
                          Some time back I posted a bunch of issues in the same post, some got a ticket, some got a mention, some got ignored...
                          See, that's your problem. Multiple issues in a thread will always mean some get lost - such is the nature of threads. Start a thread for each significant issue. (Ditto trac tickets - one issue per ticket.)
                          "Been away so long I hardly knew the place, gee it's good to be back home" - The Beatles

                          Comment

                          Working...
                          😀
                          😂
                          🥰
                          😘
                          🤢
                          😎
                          😞
                          😡
                          👍
                          👎