Tweet
As a variant maintainer who just implemented some features from V3.2 in his variant, I found a bug when running the SDL client: the new pref parser cannot parse pref-sdl.prf correctly because of the "T:\::\:" line. This line is misinterpreted as "T \ \" (using ":" as token for parsing) instead of "T : :", and then translated into n1 = NULL, n2 = NULL by the parse_prefs_t() hook. The result is that when parsing the next line, parser_freeold() crashes with a NULL pointer exception when trying to free some memory related to n1 and n2.
Since I wanted to fix this, I tried to look at the latest source code in the repository... and found that parse_prefs_t() didn't exist anymore. In fact, pref-sdl.prf doesn't exist anymore, as well as anything related to Macro Trigger configuration.
Investigating further, I found a committed changeset... that simply removed the entire macro system!!!
Will this system be replaced by something else? I have a BIG problem here... My variant is real-time based, not turn-based. It's impossible for a player to type 3-4 keys (command, item choice, direction, target...) while struggling to keep the character alive in real-time. In Vanilla Angband, the macro system is kinda pointless... but in my variant it's primordial to be able to perform an action with one key.
There's some cool stuff here: http://trac.rephial.org/wiki/InputRework. I hope this will be implemented...
Since I wanted to fix this, I tried to look at the latest source code in the repository... and found that parse_prefs_t() didn't exist anymore. In fact, pref-sdl.prf doesn't exist anymore, as well as anything related to Macro Trigger configuration.
Investigating further, I found a committed changeset... that simply removed the entire macro system!!!
Will this system be replaced by something else? I have a BIG problem here... My variant is real-time based, not turn-based. It's impossible for a player to type 3-4 keys (command, item choice, direction, target...) while struggling to keep the character alive in real-time. In Vanilla Angband, the macro system is kinda pointless... but in my variant it's primordial to be able to perform an action with one key.
There's some cool stuff here: http://trac.rephial.org/wiki/InputRework. I hope this will be implemented...
Comment