'\xff' is an int ... apparently.

[PaulBlay]

The mouseclick command from the initialization of cmd_hidden (see below) provokes the warning "warning C4245: 'initializing' : conversion from 'int' to 'unsigned char', signed/unsigned mismatch". (VC++ on level 4).

 { "Mouse click",          '\xff', do_cmd_mouseclick }

Unless I'm mistaken \xff is 255 which is the last of the unsigned char range, so I don't know why VC++ thinks it is an int...

[ajps]

Unless I'm mistaken \xff is 255 which is the last of the unsigned char range, so I don't know why VC++ thinks it is an int...

Technically is an int, in that all character constants are of integer type, not char type, regardless of their value. Still seems a strange thing to complain about though.

[PaulBlay]

Technically is an int, in that all character constants are of integer type, not char type, regardless of their value. Still seems a strange thing to complain about though.

The strange thing with that is that all the other character constants were fine with VC++. Maybe it's only the \x style it doesn't like?

[Pete Mack]

It doesn't look like an int to me... You can do a reinterpret cast, if you care about the warning:

(unsigned char) '\xff'

EDIT: I see why it's making the warning. It detects that '\xff', of type char, is out of range of MAX_CHAR ('\0x7f'), so the cast from signed to unsigned might be improper. The warning is a little opaque.

[zaimoni]

The mouseclick command from the initialization of cmd_hidden (see below) provokes the warning "warning C4245: 'initializing' : conversion from 'int' to 'unsigned char', signed/unsigned mismatch". (VC++ on level 4).

 { "Mouse click",          '\xff', do_cmd_mouseclick }

Unless I'm mistaken \xff is 255 which is the last of the unsigned char range, so I don't know why VC++ thinks it is an int...

While '\xff' is a character literal with bitpattern FF (in hex), that does promote to int, its value is only 255 on targets where char is unsigned.

The warning is harmless on the usual two's complement machines.

What I don't get is why MSVC is messing with the promotion at all.