[V] What's the rationale for ui-birth.c?

[Pete Mack]

I just compared the newish ui-birth.c/birth.c with the old birth.c (still in use in FAAngband). The new code is longer and IMO significantly more complicated.

Is there a reason for the change? (I believe the change was done by Anthony S.)

[ajps]

Yeah, the reason was to try and separate the text-based UI from the game's birth logic, it was just a rather unpleasant way to do it which happened to coincide with me not having any time to think about fixing it for a year or so.

I've just committed a change that does a better job (largely because of the removal of the autoroller), though it all needs more polish, and ui-birth.c in particular could probably still benefit from being simplified some more to be a bit closer to parts of the old birth.c setup.

[Pete Mack]

Thanks, it is a lot more comprehensible now.