I was recently doing a code review, and ran across the change
which removed const from various global string constants (and string_make)
I think that change was a step backwards. Those strings ARE supposed to be const, as in: you can't change them once they are set. The return value of string_make is the same way--it's an atomic string constructor, like
String(String, String);
You aren't really expeced to edit the return value in place...
which removed const from various global string constants (and string_make)
I think that change was a step backwards. Those strings ARE supposed to be const, as in: you can't change them once they are set. The return value of string_make is the same way--it's an atomic string constructor, like
String(String, String);
You aren't really expeced to edit the return value in place...