X11 Tile Support

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • Blue Baron
    Adept
    • Apr 2011
    • 103

    X11 Tile Support

    A long time ago, in an IRC dev meeting, I volunteered to re-add X11 tile support to Angband.

    I've rewritten X11 tile support, adding PNG support, in my personal fork of Z+Angband. I think my changes are GPL clean except for the resizeimage functions in maid-x11.c.

    In the credits of maid-x11.c, the three people mentioned are Ben Harrison, Sebastien Desvignes, and Denis Eropkin. The first two are in the list as having given permission to GPL their code. The third is not, but is in the credits as writing the BMP format support. If the BMP functions are removed from the file, could the x11 tile code that I wrote be used in Angband? I have not yet found a good open source resizing function that does smoothing.

    If you want to take a look at it, it is in my github repository at github.com/blubaron/z-angband.

    Also there are settings.c/h to read a settings file that I wrote for ticket #636, but have not tried in windows yet, just x11.
  • Magnate
    Angband Devteam member
    • May 2007
    • 5110

    #2
    IIRC Denis Eropkin was one of the only ones (possibly the only one) never traced. Takkaria will have a better memory than I, but it sounds plausible that your code could be GPL-clean. Great work - a native X port will always be helpful to have.
    "Been away so long I hardly knew the place, gee it's good to be back home" - The Beatles

    Comment

    • takkaria
      Veteran
      • Apr 2007
      • 1951

      #3
      Originally posted by Blue Baron
      A long time ago, in an IRC dev meeting, I volunteered to re-add X11 tile support to Angband.

      I've rewritten X11 tile support, adding PNG support, in my personal fork of Z+Angband. I think my changes are GPL clean except for the resizeimage functions in maid-x11.c.

      In the credits of maid-x11.c, the three people mentioned are Ben Harrison, Sebastien Desvignes, and Denis Eropkin. The first two are in the list as having given permission to GPL their code. The third is not, but is in the credits as writing the BMP format support. If the BMP functions are removed from the file, could the x11 tile code that I wrote be used in Angband? I have not yet found a good open source resizing function that does smoothing.

      If you want to take a look at it, it is in my github repository at github.com/blubaron/z-angband.

      Also there are settings.c/h to read a settings file that I wrote for ticket #636, but have not tried in windows yet, just x11.
      From the dual-licensing document I wrote a while back, "The X11 port's graphics support is non-free (by Torbjörn Lindgren), and in recent versions of Angband, the port featured clipboard copy support (by Kieron Dunbar) which was also non-free. With the removal of these features, the port is GPL-clean." [http://takkaria.org/angband-osi.html]

      Now, I have no idea why Torbjörn Lindgren is mentioned there and isn't mentioned in the code, but I did extensive research so I can only assume this to be true. I will try and work out which code exactly is his.
      takkaria whispers something about options. -more-

      Comment

      • takkaria
        Veteran
        • Apr 2007
        • 1951

        #4
        OK, so screw that, the person who actually wrote the resizing code is called Uwe Siems and it was nicked in January 2010. I can only assume there's one Uwe Siems using Linux and writing code and that person would appear to be here: https://launchpad.net/~usiems
        takkaria whispers something about options. -more-

        Comment

        • Blue Baron
          Adept
          • Apr 2011
          • 103

          #5
          Originally posted by takkaria
          OK, so screw that, the person who actually wrote the resizing code is called Uwe Siems and it was nicked in January 2010. I can only assume there's one Uwe Siems using Linux and writing code and that person would appear to be here: https://launchpad.net/~usiems
          I looked at some old Angband source recently. The smooth resizing is in 3.0.9b, which on my drive has a file date of 5/14/2007.

          Anyways, I removed the smooth resizing, so the resizing function is the same as in 2.8.3 and it seems to have been written by Sebastian Desvignes. It is in my x11-tiles branch.

          BTW my x11-tiles branch is functional. It still needs work, especially in font handling and alphablending, but its functional.

          The system menu is brought up by the escape key. Given the recent thread on more prompts, this may not be desirable.

          There is a main loop in main.c that accepts n, o, and x for new game, open game, and exit, but I don't know how it will work with stats and tests. (Pressing o opens a textui file picker to select a save game file.)

          I changed the settings file to use the same format as a windows ini file, using the code that I wrote for ticket 636. With the last commit, it should be read sound.cfg as well.

          Comment

          Working...
          😀
          😂
          🥰
          😘
          🤢
          😎
          😞
          😡
          👍
          👎